[Android] POI editor doesn't accept empty LINE input #1546

Closed
opened 2021-11-12 16:18:15 +00:00 by strump · 2 comments
Member

contact_line_validation_error

The problem is caused by next method:

bool EditableMapObject::ValidateLinePage(string const & page)
{
  if (page.empty())
    return {}; //<<<< Here should be return true;
...
}

Fixed in Pull-Request #1545

![contact_line_validation_error](/uploads/ba9523cc3ca730c7589107015739cbf7/141499075-6083b82e-a8b2-4bad-a36c-e3a52903facb.png) The problem is caused by next method: ```cpp bool EditableMapObject::ValidateLinePage(string const & page) { if (page.empty()) return {}; //<<<< Here should be return true; ... } ``` Fixed in Pull-Request #1545
biodranik commented 2021-11-12 16:19:46 +00:00 (Migrated from github.com)

@vng we should focus on a better code review ;)

`@vng` we should focus on a better code review ;)
Author
Member

mentioned in merge request !1545

mentioned in merge request !1545
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps#1546
No description provided.