organicmaps/organicmaps

Fork 18

Parse and encode coordinates in omaps.app links #7482

New issue

Open

opened 2024-02-26 19:13:56 +00:00 by biodranik · 13 comments

biodranik commented

2024-02-26 19:13:56 +00:00

(Migrated from github.com)

Historically, Organic Maps supports encoded location links: https://omaps.app/0yxdjqU7NK/Amathus

10 years ago it was important to save a few bytes when using SMS for sharing. Now it's better to share clear coordinates like this: https://omaps.app/34.71399,33.14058/Amathus

Coordinates are already supported by omaps.app url parser, but they are not supported yet on iOS and Android. The parser code should be easy to fix in the C++ code, plus add a few unit tests.

After implementing the parser and releasing app updates, the next step is to change/update the link encoder to produce readable links with coordinates instead of encoded sequence.

Historically, Organic Maps supports encoded location links: https://omaps.app/0yxdjqU7NK/Amathus 10 years ago it was important to save a few bytes when using SMS for sharing. Now it's better to share clear coordinates like this: https://omaps.app/34.71399,33.14058/Amathus Coordinates are already supported by omaps.app url parser, but they are not supported yet on iOS and Android. The parser code should be easy to fix in the C++ code, plus add a few unit tests. After implementing the parser and releasing app updates, the next step is to change/update the link encoder to produce readable links with coordinates instead of encoded sequence.

mirko77 commented

2024-02-27 12:24:59 +00:00

(Migrated from github.com)

maybe OT, but can we use the format

https://omaps.app/{latitude},{longitude}

as deeplinks to open correctly in the browser (when the app is not installed)?
Looks like it is working in the browser, but not in Android/iOS as you wrote

Related #6381

maybe OT, but can we use the format https://omaps.app/{latitude},{longitude} as deeplinks to open correctly in the browser (when the app is not installed)? Looks like it is working in the browser, but not in Android/iOS as you wrote Related #6381

biodranik commented

2024-03-01 18:53:33 +00:00

(Migrated from github.com)

@mirko77 it already works in the browser.

`@mirko77` it already works in the browser.

mirko77 commented

2024-03-01 19:33:41 +00:00

(Migrated from github.com)

@biodranik yes, but not on Android or iOS, so we cannot use it

Am I mistaken?

The other format
https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776

works in Android and iOS, but on the web, it always goes to the middle of the ocean, no matter the lat and long passed.

`@biodranik` yes, but not on Android or iOS, so we cannot use it Am I mistaken? The other format https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776 works in Android and iOS, but on the web, it always goes to the middle of the ocean, no matter the lat and long passed.

biodranik commented

2024-03-02 06:38:53 +00:00

(Migrated from github.com)

This issue is exactly about implementing it for iOS and Android.

RedAuburn commented

2024-03-07 11:47:27 +00:00

Member

The other format
https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776

Where'd this format come from? AFAIK OM doesn't support sharing multiple coords at the same time

> The other format > https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776 Where'd this format come from? AFAIK OM doesn't support sharing multiple coords at the same time

mirko77 commented

2024-03-07 11:56:31 +00:00

(Migrated from github.com)

@RedAuburn

The other format
https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776

Where'd this format come from? AFAIK OM doesn't support sharing multiple coords at the same time

From https://omaps.app/api

Show one or more points with titles on the map
om://map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776
https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776

`@RedAuburn` > > The other format > > https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776 > > Where'd this format come from? AFAIK OM doesn't support sharing multiple coords at the same time From https://omaps.app/api ``` Show one or more points with titles on the map om://map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776 https://omaps.app/map?v=1&ll=22.17319,-159.65687&n=Kalalau%20Camping&ll=22.17168,-159.66096&n=Dream%20Beach&ll=22.17182,-159.65776 ```

RedAuburn commented

2024-03-07 12:21:46 +00:00

Member

oh huh, fair enough 👍️

hemanggs commented

2025-02-09 08:05:59 +00:00

Contributor

@biodranik im trying to work on a fix to allow links of this kind https://omaps.app/34.71399,33.14058/Amathus , to be properly handled by the app , im fairly new to the codebase could you point me in the right direction as i work on this

how are existing URLs of the kind https://omaps.app/0yxdjqU7NK/Amathus, being parsed , decoded and handled withing the app
if im not wrong the intended fix is to write a c++ parser similar to https://github.com/organicmaps/url-processor/blob/master/src/ge0.ts , for the android app that can handle url's of this kind : https://omaps.app/34.71399,33.14058/Amathus ?

`@biodranik` im trying to work on a fix to allow links of this kind https://omaps.app/34.71399,33.14058/Amathus , to be properly handled by the app , im fairly new to the codebase could you point me in the right direction as i work on this - how are existing URLs of the kind https://omaps.app/0yxdjqU7NK/Amathus, being parsed , decoded and handled withing the app - if im not wrong the intended fix is to write a c++ parser similar to https://github.com/organicmaps/url-processor/blob/master/src/ge0.ts , for the android app that can handle url's of this kind : ` https://omaps.app/34.71399,33.14058/Amathus ` ?

biodranik commented

2025-02-09 08:31:00 +00:00

(Migrated from github.com)

Please check ge0 folder in the repo. Old format should also be supported, so the parser should be extended.

biodranik commented

2025-02-09 08:53:19 +00:00

(Migrated from github.com)

Note that iOS app should also properly support it. Integrating C++ code into Swift/ObjC is straightforward, and @kirylkaveryn can help you if necessary after C++ implementation with tests is ready and integrated into Android.

Note that iOS app should also properly support it. Integrating C++ code into Swift/ObjC is straightforward, and `@kirylkaveryn` can help you if necessary after C++ implementation with tests is ready and integrated into Android.

hemanggs commented

2025-02-09 08:56:57 +00:00

Contributor

Okay , got it . thanks !