organicmaps/organicmaps
32
Fork 21
Code Issues2.7k Pull requests196 Projects Releases65 Wiki Activity Actions

Minor update of liboauthcpp and a few warning fixes #7658

Closed
biodranik wants to merge 2 commits from ab-3party-oauthcpp into master
Conversation 8 Commits 2 Files changed 9 +123 -129
biodranik commented 2024-03-22 23:05:15 +00:00 (Migrated from github.com)

Thanks to @Osyotr for the MSVC build log:
https://github.com/organicmaps/organicmaps/files/14728637/organicmaps-win-build-log.txt

Thanks to `@Osyotr` for the MSVC build log: https://github.com/organicmaps/organicmaps/files/14728637/organicmaps-win-build-log.txt
biodranik commented 2024-03-23 00:23:36 +00:00 (Migrated from github.com)

Hmm, looks like liboauthcpp is not needed/used anymore when oauth2 is merged, right @strump ?

Hmm, looks like liboauthcpp is not needed/used anymore when oauth2 is merged, right `@strump` ?
Osyotr commented 2024-03-23 06:47:15 +00:00 (Migrated from github.com)

Base64/SHA1 stuff is used in other places.

Base64/SHA1 stuff is used in other places.
biodranik commented 2024-03-23 06:51:17 +00:00 (Migrated from github.com)

Base64/SHA1 stuff is used in other places.

I see, in coding. Is it the best possible implementation that we can use? The author didn't update the library for 6 years. Are there other better/faster alternatives? @Osyotr

> Base64/SHA1 stuff is used in other places. I see, in coding. Is it the best possible implementation that we can use? The author didn't update the library for 6 years. Are there other better/faster alternatives? `@Osyotr`
strump commented 2024-03-23 09:45:46 +00:00
Member

@biodranik oauth2 doesn't use liboauthcpp. Maybe we can replace it with SHA1 lib

`@biodranik` oauth2 doesn't use `liboauthcpp`. Maybe we can replace it with SHA1 lib
strump commented 2024-03-25 09:18:48 +00:00
Member

mentioned in merge request

mentioned in merge request !7333
Osyotr commented 2024-03-27 11:22:16 +00:00 (Migrated from github.com)

Are there other better/faster alternatives?

IMHO it's not worth adding an external dependency over these two algorithms.
It's possible to rip out code from https://github.com/weidai11/cryptopp (BSL-1.0).

> Are there other better/faster alternatives? IMHO it's not worth adding an external dependency over these two algorithms. It's possible to rip out code from https://github.com/weidai11/cryptopp (BSL-1.0).
rtsisyk commented 2024-04-04 06:08:01 +00:00
Owner

@biodranik oauth2 doesn't use liboauthcpp. Maybe we can replace it with SHA1 lib

Who said SHA1??? Do we still have SHA1 anywhere in the code?

> `@biodranik` oauth2 doesn't use `liboauthcpp`. Maybe we can replace it with SHA1 lib Who said SHA1??? Do we still have SHA1 anywhere in the code?
vng commented 2024-05-22 02:51:34 +00:00 (Migrated from github.com)

We no longer have liboauthcpp.

We no longer have liboauthcpp.
vng (Migrated from github.com) closed this pull request 2024-05-22 02:51:34 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
No labels
Accessibility
Address
Android
Android Auto
Android Automotive (AAOS)
API
AppGallery
AppStore
Battery and Performance
Blocker
Bookmarks and Tracks
Borders
Bug
Build
CarPlay
Classificator
Community
Core
CrashReports
Cycling
Desktop
DevEx
DevOps
dev_sandbox
Directions
Documentation
Downloader
Drape
Driving
Duplicate
Editor
Elevation
Enhancement
Epic
External Map Datasets
F-Droid
Fonts
Frequently User Reported
Fund
Generator
Good first issue
Google Play
GPS
GSoC
iCloud
Icons
iOS
Legal
Linux Desktop
Linux packaging
Linux Phone
Mac OS
Map Data
Metro
Navigation
Need Feedback
Night Mode
NLnet 2024-06-281
No Feature Parity
Opening Hours
Outdoors
POI Info
Privacy
Public Transport
Raw Idea
Refactoring
Regional
Regression
Releases
RoboTest
Route Planning
Routing
Ruler
Search
Security
Styles
Tests
Track Recording
Translations
TTS
UI
UX
Walk Navigation
Watches
Web
Wikipedia
Windows
Won't fix
World Map
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps#7658
No description provided.
Delete branch "ab-3party-oauthcpp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?