Sharing location to Organic Maps leads to crash #9048

New issue

Open

opened 2024-08-21 17:51:11 +00:00 by soshial · 7 comments

soshial commented

2024-08-21 17:51:11 +00:00

(Migrated from github.com)

Describe the issue
Sharing location to Organic Maps leads to crash

Steps to reproduce

Go to Fossify Gallery App and open any photo with location in EXIF
Click on "Settings (the dots icon)" and then "Show on map"
Crash

fun openLocation(exif....) {
    val latLon = FloatArray(2)
    if (exif.getLatLong(latLon)) {
        showLocationOnMap("${latLon[0]}, ${latLon[1]}")
    } else {
        toast(R.string.unknown_location)
    }
}

fun Activity.showLocationOnMap(coordinates: String) {
    val uriBegin = "geo:${coordinates.replace(" ", "")}"
    val encodedQuery = Uri.encode(coordinates)
    val uriString = "$uriBegin?q=$encodedQuery&z=16"
    val intent = Intent(Intent.ACTION_VIEW, Uri.parse(uriString))
    launchActivityIntent(intent)
}

Expected behaviour
No crash.

Screenshots
If applicable, add screenshots or screen recordings to help explain your problem.

System information:

Operating system and its version: [Android 14]
Organic Maps version: 2024.08.15-21-FDroid
Device Model: Samsung S22

Additional context
Please add any other context or comments here that may be useful.

**Describe the issue** Sharing location to Organic Maps leads to crash **Steps to reproduce** 1. Go to [Fossify Gallery App](https://f-droid.org/en/packages/org.fossify.gallery/) and open any photo with location in EXIF 2. Click on "Settings (the dots icon)" and then "Show on map" 3. Crash <img width="1135" alt="Screenshot 2024-08-22 at 09 10 00" src="https://github.com/user-attachments/assets/173d99fa-facf-41d2-8994-825bb635bc86"> ```kotlin fun openLocation(exif....) { val latLon = FloatArray(2) if (exif.getLatLong(latLon)) { showLocationOnMap("${latLon[0]}, ${latLon[1]}") } else { toast(R.string.unknown_location) } } fun Activity.showLocationOnMap(coordinates: String) { val uriBegin = "geo:${coordinates.replace(" ", "")}" val encodedQuery = Uri.encode(coordinates) val uriString = "$uriBegin?q=$encodedQuery&z=16" val intent = Intent(Intent.ACTION_VIEW, Uri.parse(uriString)) launchActivityIntent(intent) } ``` **Expected behaviour** No crash. **Screenshots** If applicable, add screenshots or screen recordings to help explain your problem. **System information:** - Operating system and its version: [Android 14] - Organic Maps version: 2024.08.15-21-FDroid - Device Model: Samsung S22 **Additional context** Please add any other context or comments here that may be useful.

biodranik commented

2024-08-21 20:28:19 +00:00

(Migrated from github.com)

@soshial what is Simple Gallery app, and how exactly are you opening OM from it? Do you have a crash callstack?

`@soshial` what is Simple Gallery app, and how exactly are you opening OM from it? Do you have a crash callstack?

RicoElectrico commented

2024-08-21 22:04:44 +00:00

(Migrated from github.com)

what is Simple Gallery app

https://play.google.com/store/apps/details?id=com.simplemobiletools.gallery.pro (and https://play.google.com/store/apps/details?id=com.simplemobiletools.gallery non-pro version)

> what is Simple Gallery app https://play.google.com/store/apps/details?id=com.simplemobiletools.gallery.pro (and https://play.google.com/store/apps/details?id=com.simplemobiletools.gallery non-pro version)

soshial commented

2024-08-22 07:04:04 +00:00

(Migrated from github.com)

I added a link to the app, @biodranik
And a crash callstack as well

I added a link to the app, `@biodranik` And a crash callstack as well

soshial commented

2024-08-25 18:59:16 +00:00

(Migrated from github.com)

At the moment, I cannot reproduce the crash even though it reproduced each time 3 days ago. I assure you, I am not crazy :)

biodranik commented

2024-08-25 19:41:01 +00:00

(Migrated from github.com)