[android] Track recorder toast is shown unnecessarily #9243

New issue

Open

opened 2024-09-07 22:43:43 +00:00 by RicoElectrico · 5 comments

RicoElectrico commented

2024-09-07 22:43:43 +00:00

(Migrated from github.com)

Describe the issue
Every time MwmActivity is being re-created the toast about track recording is being shown

Steps to reproduce

Enable track recording
Rotate device or switch from and back to OM
Track recording toast is being shown

Expected behaviour
The toast is shown only as a result of user action i.e. tapping 'start recording'

System information:

Operating system and its version: Android 14
Organic Maps version: 2024.09.07-5
Device Model: Samsung Galaxy S23

**Describe the issue** Every time MwmActivity is being re-created the toast about track recording is being shown **Steps to reproduce** 1. Enable track recording 2. Rotate device or switch from and back to OM 3. Track recording toast is being shown **Expected behaviour** The toast is shown only as a result of user action i.e. tapping 'start recording' **System information:** - Operating system and its version: Android 14 - Organic Maps version: 2024.09.07-5 - Device Model: Samsung Galaxy S23

RicoElectrico commented

2024-09-08 09:04:53 +00:00

(Migrated from github.com)

CC @kavikhalique @rtsisyk

CC `@kavikhalique` `@rtsisyk`

rtsisyk commented

2024-09-08 12:54:47 +00:00

Owner

Thanks for reporting. I noticed this behaviour, but I thought that it was OK. Is it truly bothering you?

RicoElectrico commented

2024-09-08 13:17:11 +00:00

(Migrated from github.com)

I personally think toasts should be limited to minimum. There's already an indication on the status bar and a blue dot, right?
Certainly showing that toast on each device rotation is janky. Feels like something our competition would do 🤣

I personally think toasts should be limited to minimum. There's already an indication on the status bar and a blue dot, right? Certainly showing that toast on each device rotation is janky. Feels like something our competition would do :rofl:

kavikhalique commented

2024-09-15 16:02:48 +00:00

(Migrated from github.com)

I personally think toasts should be limited to minimum. There's already an indication on the status bar and a blue dot, right? Certainly showing that toast on each device rotation is janky. Feels like something our competition would do 🤣

This issues was caused by other issue which has been fixed now in latest track recorder. Can you please confirm it?

> I personally think toasts should be limited to minimum. There's already an indication on the status bar and a blue dot, right? Certainly showing that toast on each device rotation is janky. Feels like something our competition would do 🤣 This issues was caused by other issue which has been fixed now in latest track recorder. Can you please confirm it?

RicoElectrico commented

2024-09-16 16:03:13 +00:00

(Migrated from github.com)

This issues was caused by other issue which has been fixed now in latest track recorder. Can you please confirm it?

If you meant the master branch, then the issue is still there.

> This issues was caused by other issue which has been fixed now in latest track recorder. Can you please confirm it? If you meant the master branch, then the issue is still there.