organicmaps/organicmaps

Fork 18

[android] GetEnv() exception when destroying async callback from MwmApplication_nativeInitFramework #9397

New issue

Open

opened 2024-09-29 16:02:02 +00:00 by vng · 8 comments

vng commented

2024-09-29 16:02:02 +00:00

(Migrated from github.com)

2024.09.19-2-Google 45 users, 57 crashes.

terminating due to uncaught exception of type RootException: RootException /Users/roman/code/organicmaps/organicmaps/android/app/src/main/cpp/app/organicmaps/core/jni_helper.cpp:81, "Can't get JNIEnv. Is the thread attached to JVM?"

backtrace:
  #00  pc 0x000000000005b650  /apex/com.android.runtime/lib64/bionic/libc.so (abort+168)
  #01  pc 0x0000000000d7eb28  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (abort_message+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #02  pc 0x0000000000d7e420  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (demangling_terminate_handler()+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #03  pc 0x0000000000d7e2e0  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__terminate(void (*)())+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #04  pc 0x0000000000d7e280  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::terminate()+56) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #05  pc 0x00000000003f42ec  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (__clang_call_terminate+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #06  pc 0x0000000000423104  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__shared_ptr_pointer<_jobject**, jni::global_ref_deleter, std::__ndk1::allocator<_jobject*>>::__on_zero_shared()+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #07  pc 0x000000000042a0d0  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__function::__func<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0, std::__ndk1::allocator<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0>, void ()>::destroy()+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #08  pc 0x000000000051eeb0  /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (void* std::__ndk1::__thread_proxy[abi:ne180000]<std::__ndk1::tuple<std::__ndk1::unique_ptr<std::__ndk1::__thread_struct, std::__ndk1::default_delete<std::__ndk1::__thread_struct>>, void (*)(std::__ndk1::function<void ()>&&), std::__ndk1::__bind<Framework::LoadMapsAsync(std::__ndk1::function<void ()>&&)::$_0>>>(void*)+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500)
  #09  pc 0x00000000000c3644  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+208)
  #10  pc 0x000000000005cfa4  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+68)

2024.09.19-2-Google 45 users, 57 crashes. terminating due to uncaught exception of type RootException: RootException /Users/roman/code/organicmaps/organicmaps/android/app/src/main/cpp/app/organicmaps/core/jni_helper.cpp:81, "Can't get JNIEnv. Is the thread attached to JVM?" ``` backtrace: #00 pc 0x000000000005b650 /apex/com.android.runtime/lib64/bionic/libc.so (abort+168) #01 pc 0x0000000000d7eb28 /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (abort_message+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #02 pc 0x0000000000d7e420 /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (demangling_terminate_handler()+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #03 pc 0x0000000000d7e2e0 /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__terminate(void (*)())+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #04 pc 0x0000000000d7e280 /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::terminate()+56) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #05 pc 0x00000000003f42ec /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (__clang_call_terminate+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #06 pc 0x0000000000423104 /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__shared_ptr_pointer<_jobject**, jni::global_ref_deleter, std::__ndk1::allocator<_jobject*>>::__on_zero_shared()+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #07 pc 0x000000000042a0d0 /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__function::__func<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0, std::__ndk1::allocator<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0>, void ()>::destroy()+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #08 pc 0x000000000051eeb0 /data/app/~~faMZ-XY9ygsjMyxoVOj-4Q==/app.organicmaps-_jzOZQWy_6zHKVlV4GKJqA==/split_config.arm64_v8a.apk!liborganicmaps.so (void* std::__ndk1::__thread_proxy[abi:ne180000]<std::__ndk1::tuple<std::__ndk1::unique_ptr<std::__ndk1::__thread_struct, std::__ndk1::default_delete<std::__ndk1::__thread_struct>>, void (*)(std::__ndk1::function<void ()>&&), std::__ndk1::__bind<Framework::LoadMapsAsync(std::__ndk1::function<void ()>&&)::$_0>>>(void*)+16384) (BuildId: 099aa65663641c14348e3cca198868499d0cc500) #09 pc 0x00000000000c3644 /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+208) #10 pc 0x000000000005cfa4 /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+68) ```

vng commented

2024-09-29 16:35:46 +00:00

(Migrated from github.com)

#6139

https://git.omaps.dev/organicmaps/organicmaps/issues/6139

vng commented

2024-09-30 01:28:22 +00:00

(Migrated from github.com)

mentioned in merge request !9400

vng commented

2024-09-30 12:23:06 +00:00

(Migrated from github.com)

Check Framework::LoadMapsAsync function:
This may happen if RegisterAllMaps or InitAfterWorldLoaded fails (with some uncaught exception) and the callback is destroyed in the load thread context without going further to GetPlatform().RunTask(Platform::Thread::Gui.

Check ```Framework::LoadMapsAsync``` function: This may happen if RegisterAllMaps or InitAfterWorldLoaded fails (with some uncaught exception) and the callback is destroyed in the load thread context without going further to ```GetPlatform().RunTask(Platform::Thread::Gui```.

vng commented

2024-11-04 19:25:53 +00:00

(Migrated from github.com)

Some context from the detailed log:

11-03 16:17:34.447 I/OMcore  (11708): (Thread-11) map/framework.cpp:140 RegisterMap(): Loaded Estonia_West map, of version 241017
11-03 16:17:34.451 I/OMcore  (11708): (Thread-11) map/framework.cpp:140 RegisterMap(): Loaded World map, of version 241017
11-03 16:17:34.454 I/OMcore  (11708): (Thread-11) map/framework.cpp:140 RegisterMap(): Loaded WorldCoasts map, of version 241017
11-03 16:17:34.463 E/OMcore  (11708): (Thread-12) core/jni_helper.cpp:81 GetEnv(): Can't get JNIEnv. Is the thread attached to JVM? -2
11-03 16:17:34.464 E/libc++abi(11708): terminating due to uncaught exception of type RootException: RootException /home/runner/work/organicmaps/organicmaps/android/app/src/main/cpp/app/organicmaps/core/jni_helper.cpp:82, "Can't get JNIEnv. Is the thread attached to JVM? -2"
--------- beginning of crash
11-03 16:17:34.468 F/libc    (11708): Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 11755 (Thread-12), pid 11708 (app.organicmaps)
11-03 16:17:34.514 I/OMcore  (11708): (main) platform/platform_unix_impl.cpp:119 GetWritableStorageStatus(): statfs return = 0 ; block size = 4096 ; blocks available = 11332979
11-03 16:17:34.514 I/OMcore  (11708): (main) platform/platform_unix_impl.cpp:128 GetWritableStorageStatus(): Free space check: requested = 0 ; available = 46419881984

Strange that after RegisterAllMaps the callback is destroyed in Thread-12, but we do move callback into the (main) thread.

Some context from the detailed log: ``` 11-03 16:17:34.447 I/OMcore (11708): (Thread-11) map/framework.cpp:140 RegisterMap(): Loaded Estonia_West map, of version 241017 11-03 16:17:34.451 I/OMcore (11708): (Thread-11) map/framework.cpp:140 RegisterMap(): Loaded World map, of version 241017 11-03 16:17:34.454 I/OMcore (11708): (Thread-11) map/framework.cpp:140 RegisterMap(): Loaded WorldCoasts map, of version 241017 11-03 16:17:34.463 E/OMcore (11708): (Thread-12) core/jni_helper.cpp:81 GetEnv(): Can't get JNIEnv. Is the thread attached to JVM? -2 11-03 16:17:34.464 E/libc++abi(11708): terminating due to uncaught exception of type RootException: RootException /home/runner/work/organicmaps/organicmaps/android/app/src/main/cpp/app/organicmaps/core/jni_helper.cpp:82, "Can't get JNIEnv. Is the thread attached to JVM? -2" --------- beginning of crash 11-03 16:17:34.468 F/libc (11708): Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 11755 (Thread-12), pid 11708 (app.organicmaps) 11-03 16:17:34.514 I/OMcore (11708): (main) platform/platform_unix_impl.cpp:119 GetWritableStorageStatus(): statfs return = 0 ; block size = 4096 ; blocks available = 11332979 11-03 16:17:34.514 I/OMcore (11708): (main) platform/platform_unix_impl.cpp:128 GetWritableStorageStatus(): Free space check: requested = 0 ; available = 46419881984 ``` Strange that after RegisterAllMaps the callback is destroyed in Thread-12, but we do _move_ callback into the (main) thread.

biodranik commented

2024-12-04 17:20:40 +00:00

(Migrated from github.com)

246 affected users, this should be prioritized, as Google may decrease OM rank due to crashes. @vng @rtsisyk

backtrace:
  #00  pc 0x000000000005b770  /apex/com.android.runtime/lib64/bionic/libc.so (abort+168)
  #01  pc 0x0000000000d82798  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (abort_message+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #02  pc 0x0000000000d82090  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (demangling_terminate_handler()+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #03  pc 0x0000000000d81f50  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__terminate(void (*)())+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #04  pc 0x0000000000d81ef0  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::terminate()+56) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #05  pc 0x00000000003f6160  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (__clang_call_terminate+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #06  pc 0x000000000042569c  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__shared_ptr_pointer<_jobject**, jni::make_global_ref(_jobject*)::$_0, std::__ndk1::allocator<_jobject*>>::__on_zero_shared()+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #07  pc 0x000000000042c8b8  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__function::__func<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0, std::__ndk1::allocator<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0>, void ()>::destroy()+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #08  pc 0x0000000000521b20  /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (void* std::__ndk1::__thread_proxy[abi:ne180000]<std::__ndk1::tuple<std::__ndk1::unique_ptr<std::__ndk1::__thread_struct, std::__ndk1::default_delete<std::__ndk1::__thread_struct>>, void (*)(std::__ndk1::function<void ()>&&), std::__ndk1::__bind<Framework::LoadMapsAsync(std::__ndk1::function<void ()>&&)::$_0>>>(void*)+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682)
  #09  pc 0x00000000000c3954  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+208)
  #10  pc 0x000000000005d0c4  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+68)

[246 affected users](https://play.google.com/console/u/0/developers/8084273541548442467/app/4972992444534608608/vitals/crashes/43f43989479cdc55f2c22836c376831d/details?days=28), this should be prioritized, as Google may decrease OM rank due to crashes. `@vng` `@rtsisyk` ``` backtrace: #00 pc 0x000000000005b770 /apex/com.android.runtime/lib64/bionic/libc.so (abort+168) #01 pc 0x0000000000d82798 /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (abort_message+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #02 pc 0x0000000000d82090 /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (demangling_terminate_handler()+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #03 pc 0x0000000000d81f50 /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__terminate(void (*)())+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #04 pc 0x0000000000d81ef0 /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::terminate()+56) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #05 pc 0x00000000003f6160 /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (__clang_call_terminate+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #06 pc 0x000000000042569c /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__shared_ptr_pointer<_jobject**, jni::make_global_ref(_jobject*)::$_0, std::__ndk1::allocator<_jobject*>>::__on_zero_shared()+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #07 pc 0x000000000042c8b8 /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (std::__ndk1::__function::__func<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0, std::__ndk1::allocator<Java_app_organicmaps_MwmApplication_nativeInitFramework::$_0>, void ()>::destroy()+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #08 pc 0x0000000000521b20 /data/app/~~1IRO4qvFY3BOjVe8D1ly3g==/app.organicmaps-9MlR0sEmF93DQfrCYn5abg==/split_config.arm64_v8a.apk!liborganicmaps.so (void* std::__ndk1::__thread_proxy[abi:ne180000]<std::__ndk1::tuple<std::__ndk1::unique_ptr<std::__ndk1::__thread_struct, std::__ndk1::default_delete<std::__ndk1::__thread_struct>>, void (*)(std::__ndk1::function<void ()>&&), std::__ndk1::__bind<Framework::LoadMapsAsync(std::__ndk1::function<void ()>&&)::$_0>>>(void*)+16384) (BuildId: f7b5ff69381481dcb158e2dfff533cd9df1af682) #09 pc 0x00000000000c3954 /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+208) #10 pc 0x000000000005d0c4 /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+68) ```

vng commented

2025-01-14 21:06:14 +00:00

(Migrated from github.com)

mentioned in merge request !10067

AndrewShkrob commented

2025-01-14 22:05:04 +00:00

Member

8d6b3a3d2f/android/app/src/main/cpp/app/organicmaps/platform/GuiThread.cpp (L33-L47)

We call GuiThread::Push from some random thread. Push calls jni::GetEnv(). jni::GetEnv() requires calling thread to be attached to jvm. Why do we expect that some random thread would be attached to jvm?

The fastest and easiest solution would be to wrap the jni calls with AndroidThreadAttachToJVM and AndroidThreadDetachFromJVM from base/thread.cpp.
Is it a good solution? Probably, not.

I was looking into rewriting this class with <android/looper.h> to get the mainThreadLooper in cpp and eliminate tasks forwarding from cpp to java and back to cpp, but no luck so far.

https://github.com/organicmaps/organicmaps/blob/8d6b3a3d2f2afbf9cd6061aad2fade79aaad8e39/android/app/src/main/cpp/app/organicmaps/platform/GuiThread.cpp#L33-L47 We call `GuiThread::Push` from some random thread. `Push` calls `jni::GetEnv()`. `jni::GetEnv()` requires calling thread to be attached to jvm. Why do we expect that some random thread would be attached to jvm? The fastest and easiest solution would be to wrap the jni calls with `AndroidThreadAttachToJVM` and `AndroidThreadDetachFromJVM` from `base/thread.cpp`. Is it a good solution? Probably, not. I was looking into rewriting this class with `<android/looper.h>` to get the mainThreadLooper in cpp and eliminate tasks forwarding from cpp to java and back to cpp, but no luck so far.

vng commented

2025-01-15 15:11:56 +00:00

(Migrated from github.com)

GuiThread::Push is also called from base/thread.cpp thread wrappers.

LoadMapsAsync -> threads::SimpleThread -> GetPlatform().RunTask(Gui, ...) -> GuiThread::Push

GuiThread::Push is also called from base/thread.cpp thread wrappers. LoadMapsAsync -> threads::SimpleThread -> GetPlatform().RunTask(Gui, ...) -> GuiThread::Push