organicmaps/protobuf
13
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Use 0 as the default value for all enums, rather than finding the actual enum value name

Browse source 
This will make it easier to change the enum value names, as it reduces the number of places they're used.
This commit is contained in:
Jon Skeet 2016-04-08 10:02:04 +01:00
parent 3ffbdd712f
commit 2a197b3eb0
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/google/protobuf/compiler/csharp/csharp_field_base.cc
View file

@ -306,7 +306,9 @@ std::string FieldGeneratorBase::default_value() {
std::string FieldGeneratorBase::default_value(const FieldDescriptor* descriptor) {
switch (descriptor->type()) {
case FieldDescriptor::TYPE_ENUM:
return type_name() + "." + descriptor->default_value_enum()->name();
// All proto3 enums have a default value of 0, and there's an implicit conversion from the constant 0 to
// any C# enum. This means we don't need to work out what we actually mapped the enum value name to.
return "0";
case FieldDescriptor::TYPE_MESSAGE:
case FieldDescriptor::TYPE_GROUP:
if (IsWrapperType(descriptor)) {