diff --git a/src/ProtocolBuffers/GeneratedMessage.cs b/src/ProtocolBuffers/GeneratedMessage.cs index 7b4ae209..d8747599 100644 --- a/src/ProtocolBuffers/GeneratedMessage.cs +++ b/src/ProtocolBuffers/GeneratedMessage.cs @@ -84,20 +84,14 @@ namespace Google.ProtocolBuffers { public override bool IsInitialized { get { - /* if (!DescriptorForType.HasRequiredFields) { - return true; - }*/ - // Check that all required fields are present. foreach (FieldDescriptor field in DescriptorForType.Fields) { + // Check that all required fields are present. if (field.IsRequired && !HasField(field)) { return false; } - } - - // Check that embedded messages are initialized. - // This code is similar to that in AbstractMessage, but we don't - // fetch all the field values - just the ones we need to. - foreach (FieldDescriptor field in DescriptorForType.Fields) { + // Check that embedded messages are initialized. + // This code is similar to that in AbstractMessage, but we don't + // fetch all the field values - just the ones we need to. if (field.MappedType == MappedType.Message) { if (field.IsRepeated) { // We know it's an IList, but not the exact type - so diff --git a/todo.txt b/todo.txt index 41b33eec..f3d6fb4d 100644 --- a/todo.txt +++ b/todo.txt @@ -2,7 +2,6 @@ Current task list (not in order) Diff stuff -- Refactor IsInitialized - Performance framework - Optionally remove dependencies to core and csharp options - Remove multifile support