organicmaps/protobuf
13
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Just comments.

Browse source
This commit is contained in:
Jon Skeet 2008-08-15 21:15:41 +01:00
parent 3fa72c5556
commit 984eb9c27a
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
csharp/ProtocolBuffers/AbstractBuilder.cs
View file

@ -121,7 +121,7 @@ namespace Google.ProtocolBuffers {
// them to insure that they don't change after verification (since
// the Message interface itself cannot enforce immutability of
// implementations).
// TODO(jonskeet): Provide a function somewhere called makeDeepCopy()
// TODO(jonskeet): Provide a function somewhere called MakeDeepCopy()
// which allows people to make secure deep copies of messages.
foreach (KeyValuePair<FieldDescriptor, object> entry in other.AllFields) {
FieldDescriptor field = entry.Key;

6
src/google/protobuf/compiler/csharp/csharp_primitive_field.cc
View file

@ -243,10 +243,10 @@ GenerateMembers(io::Printer* printer) const {
"public scg::IList<$type$> $capitalized_name$List {\r\n"
" get { return $name$_; }\r\n" // note: unmodifiable list
"}\r\n"
"public int $capitalized_name$Count {\r\n" // TODO(jonskeet): Remove?
"public int $capitalized_name$Count {\r\n"
" get { return $name$_.Count; }\r\n"
"}\r\n"
"public $type$ Get$capitalized_name$(int index) {\r\n" // TODO(jonskeet): Remove?
"public $type$ Get$capitalized_name$(int index) {\r\n"
" return $name$_[index];\r\n"
"}\r\n");
}
@ -257,7 +257,7 @@ GenerateBuilderMembers(io::Printer* printer) const {
// Note: We return an unmodifiable list because otherwise the caller
// could hold on to the returned list and modify it after the message
// has been built, thus mutating the message which is supposed to be
// immutable.
// immutable. This unfortunately limits the use for collection initializers...
"public scg::IList<$type$> $capitalized_name$List {\r\n"
" get { return pbc::Lists<$type$>.AsReadOnly(result.$name$_); }\r\n"
"}\r\n"