organicmaps/protobuf
13
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Increase the allocated_size_ should be after allocation. Otherwise there might have segmentation fault if allocation throws an exception.

Browse source
This commit is contained in:
jieluo@google.com 2014-07-24 17:31:41 +00:00
parent e6726e2150
commit 9eda53a6f1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/google/protobuf/repeated_field.h
View file

@ -897,8 +897,8 @@ inline typename TypeHandler::Type* RepeatedPtrFieldBase::Add() {
return cast<TypeHandler>(elements_[current_size_++]);
}
if (allocated_size_ == total_size_) Reserve(total_size_ + 1);
++allocated_size_;
typename TypeHandler::Type* result = TypeHandler::New();
++allocated_size_;
elements_[current_size_++] = result;
return result;
}