organicmaps/protobuf
13
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Optimize Java serialization of small messages to streams. Patch from Evan Jones.

Browse source
This commit is contained in:
kenton@google.com 2009-11-02 18:50:19 +00:00
parent 573989f782
commit f85d70f9e4
3 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CONTRIBUTORS.txt
View file

@ -76,3 +76,5 @@ Patch contributors:
* HPUX support.
Oliver Jowett <oliver.jowett@gmail.com>
* Detect whether zlib is new enough in configure script.
Evan Jones <evanj@mit.edu>
* Optimize Java serialization code when writing a small message to a stream.

11
java/src/main/java/com/google/protobuf/AbstractMessageLite.java
View file

@ -72,13 +72,20 @@ public abstract class AbstractMessageLite implements MessageLite {
}
public void writeTo(final OutputStream output) throws IOException {
final CodedOutputStream codedOutput = CodedOutputStream.newInstance(output);
final int bufferSize =
CodedOutputStream.computePreferredBufferSize(getSerializedSize());
final CodedOutputStream codedOutput =
CodedOutputStream.newInstance(output, bufferSize);
writeTo(codedOutput);
codedOutput.flush();
}
public void writeDelimitedTo(final OutputStream output) throws IOException {
final CodedOutputStream codedOutput = CodedOutputStream.newInstance(output);
final int serialized = getSerializedSize();
final int bufferSize = CodedOutputStream.computePreferredBufferSize(
CodedOutputStream.computeRawVarint32Size(serialized) + serialized);
final CodedOutputStream codedOutput =
CodedOutputStream.newInstance(output, bufferSize);
codedOutput.writeRawVarint32(getSerializedSize());
writeTo(codedOutput);
codedOutput.flush();

12
java/src/main/java/com/google/protobuf/CodedOutputStream.java
View file

@ -60,6 +60,18 @@ public final class CodedOutputStream {
*/
public static final int DEFAULT_BUFFER_SIZE = 4096;
/**
* Returns the buffer size to efficiently write dataLength bytes to this
* CodedOutputStream. Used by AbstractMessageLite.
*
* @return the buffer size to efficiently write dataLength bytes to this
* CodedOutputStream.
*/
static int computePreferredBufferSize(int dataLength) {
if (dataLength > DEFAULT_BUFFER_SIZE) return DEFAULT_BUFFER_SIZE;
return dataLength;
}
private CodedOutputStream(final byte[] buffer, final int offset,
final int length) {
output = null;