From 0cb4f025791f7c17f8ec09a1c12b0cb107518fad Mon Sep 17 00:00:00 2001
From: Arseny Kapoulkine <arseny.kapoulkine@gmail.com>
Date: Fri, 7 Oct 2022 21:46:27 -0700
Subject: [PATCH] Final tweaks after #522

This cleans up xml_attribute::set_value to be uniform wrt
xml_node::set_value and xml_text::set_value - for now we duplicate the
body since the logic is trivial and this keeps debug performance
excellent.
---
 src/pugixml.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/pugixml.cpp b/src/pugixml.cpp
index bc9fd82..6b16dbb 100644
--- a/src/pugixml.cpp
+++ b/src/pugixml.cpp
@@ -5381,7 +5381,9 @@ namespace pugi
 
 	PUGI__FN bool xml_attribute::set_value(const char_t* rhs)
 	{
-		return set_value(rhs, impl::strlength(rhs));
+		if (!_attr) return false;
+
+		return impl::strcpy_insitu(_attr->value, _attr->header, impl::xml_memory_page_value_allocated_mask, rhs, impl::strlength(rhs));
 	}
 
 	PUGI__FN bool xml_attribute::set_value(int rhs)