organicmaps/pugixml
13
Fork 0
Code Issues 1 Pull requests Projects Releases Wiki Activity Actions

Fix parsing of integers that start with +

Browse source 
This matches the format strtol supports.
This commit is contained in:
Arseny Kapoulkine 2015-09-21 00:35:57 -07:00
parent b0b84277fa
commit 3229e67712
2 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/pugixml.cpp
View file

@ -4440,7 +4440,7 @@ PUGI__NS_BEGIN
bool negative = (*s == '-');
s += negative;
s += (*s == '+' || *s == '-');
bool overflow = false;

19
tests/test_dom_traverse.cpp
View file

@ -1224,4 +1224,21 @@ TEST_XML(dom_as_ullong_hex_overflow, "<node attr1='-0x1' attr2='0x10000000000000
CHECK(node.attribute(STR("attr2")).as_ullong() == 18446744073709551615ull);
CHECK(node.attribute(STR("attr3")).as_ullong() == 18446744073709551615ull);
}
#endif
#endif
TEST_XML(dom_as_int_plus, "<node attr1='+1' attr2='+0xa' />")
{
xml_node node = doc.child(STR("node"));
CHECK(node.attribute(STR("attr1")).as_int() == 1);
CHECK(node.attribute(STR("attr1")).as_uint() == 1);
CHECK(node.attribute(STR("attr2")).as_int() == 10);
CHECK(node.attribute(STR("attr2")).as_uint() == 10);
#ifdef PUGIXML_HAS_LONG_LONG
CHECK(node.attribute(STR("attr1")).as_llong() == 1);
CHECK(node.attribute(STR("attr1")).as_ullong() == 1);
CHECK(node.attribute(STR("attr2")).as_llong() == 10);
CHECK(node.attribute(STR("attr2")).as_ullong() == 10);
#endif
}