Merge pull request #492 from KDAB/fix-default-visibility

Correctly set default visibility on non-windows compilers
2022-09-27 12:53:06 -07:00 · 2022-09-27 12:53:06 -07:00 · bcf483c3b7
commit bcf483c3b7
parent 521b2cd854 173a263490
1 changed files with 3 additions and 1 deletions
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@ -111,7 +111,9 @@ if (BUILD_SHARED_LIBS)
      ${PUGIXML_BUILD_DEFINES}
      ${PUGIXML_PUBLIC_DEFINITIONS}
    PRIVATE
-      $<$<CXX_COMPILER_ID:MSVC>:PUGIXML_API=__declspec\(dllexport\)>)
+      $<$<CXX_COMPILER_ID:MSVC>:PUGIXML_API=__declspec\(dllexport\)>
+      $<IF:$<CXX_COMPILER_ID:MSVC>,,PUGIXML_API=__attribute__\(\(visibility\("default"\)\)\)>
+    )
  target_compile_options(pugixml-shared
    PRIVATE
      ${msvc-rt-mtd-shared}