Commit graph

120 commits

Author SHA1 Message Date
Alexander Borsuk
15d3fcc149 Alexey's hotfix for validator 2022-10-07 23:20:44 +02:00
Alexey Zakharenkov
7df15a390d Check route ref uniqueness within a city 2022-04-21 19:19:33 +03:00
Alexey Zakharenkov
d28b2f1503 Make "Route has no stops" a warning, not an error 2022-04-21 14:24:42 +03:00
Alexey Zakharenkov
ef5bbab672 Return "error_if"-logic for tram lines count 2021-11-08 12:22:57 +03:00
Claudius
0bc8f779ae More user friendly UX for severity level messaging
More user friendly severity level messaging

Included the changes I mentioned in [my earlier comment](https://github.com/alexey-zakharenkov/subways/pull/14#issuecomment-948391863) to:
- Add section headers to the different severity level messages
- Change the errors red colour to a accessible one
- Changed copy of entrance errors from "e:" to "ent:"
- Shortened an error message slightly to reduce possibility of it wrapping into a new line and have the "Under construction" keyword at the beginning of the sentence

CSS property width=fit-content is not supported in Firefox; shorten tooltip text; exclude empty validation message during HTML genertion
2021-11-03 10:56:10 +01:00
Alexey Zakharenkov
0a1115f4ec Make three levels of severity for validation errors 2021-10-16 00:50:02 +03:00
Alexey Zakharenkov
6596d9789c PEPify-8 with black -l 79 -S 2021-08-02 15:45:56 +03:00
Alexey Zakharenkov
cc0fee6167
Update subway_structure.py 2021-04-20 00:24:41 +03:00
Alexey Zakharenkov
e64fbbee97 Fixes after review 2020-10-13 11:21:56 +03:00
Alexey Zakharenkov
14e96bb806 While checking stops order on tracks, take into account repeated tracks/stations in a route like Line 5 of Oslo metro or spoon-shaped Line 7bis in Paris 2020-10-13 11:21:56 +03:00
Alexey Zakharenkov
6eb7ec8586 While checking stops order on tracks, take into account that more than one stop can reside on the same track segment 2020-10-13 11:21:56 +03:00
Alexey Zakharenkov
7e575b36cd Check stops order on tracks 2020-10-13 11:21:56 +03:00
Alexey Zakharenkov
75dd90e02e Disallow railway=station tag on relations other than multipolygons, in particular on stop_areas 2020-08-31 18:51:44 +03:00
Alexey Zakharenkov
9b74358c1b Recursively calculate centers of all relations 2020-08-21 19:02:48 +03:00
Zakharenkov Alexey
1b0888c6f0 Avoid false 'Missing station=<mode>' error 2020-07-23 15:14:42 +03:00
Maksim Andrianov
48fe701c03
Merge pull request #94 from alexey-zakharenkov/check-stop_area_group-members
Check members of a stop_area_group
2020-07-16 17:43:15 +03:00
Alexey Zakharenkov
d812c11261 Discard all members of a stop_area_group that are not stop_areas 2020-07-15 15:36:55 +03:00
Alexey Zakharenkov
b90b03f6e9 Improve error message 2020-07-08 17:56:09 +03:00
Alexey Zakharenkov
16b62ca63c Make an error message more informative 2020-03-18 14:49:33 +03:00
Alexey Zakharenkov
aa94bf8b45 Skip route members in 'inactive' role 2020-02-20 18:10:58 +03:00
Alexey Zakharenkov
5c8bfb1667 Separate processing of 3 types of errors 2020-02-20 15:30:04 +03:00
Alexey Zakharenkov
d79efc3d26 Check actual stop/platform elements role in routes 2020-01-29 12:58:39 +03:00
Alexey Zakharenkov
27cb1dd04e Report more correct node as hole spot 2020-01-09 12:56:18 +03:00
Alexey Zakharenkov
18ef5d5466 Fix a syntax bug 2019-07-05 16:37:09 +03:00
Alexey Zakharenkov
cc8339c545 Do not consider a duplication two platforms in a route: an exit-only one and an entry-only one 2019-07-05 16:35:22 +03:00
Sergey Yershov
57c459175a
Merge pull request #79 from alexey-zakharenkov/continue-on-bad-bbox
Recover after 'Item is not in dataset' exception to continue validating other cities
2019-07-05 13:24:27 +03:00
Alexey Zakharenkov
a1ecc7429d City.errors array may be needed earlier than you thought 2019-07-02 18:18:23 +03:00
Alexey Zakharenkov
45a214892c No need to validate() a city after critical error 2019-07-02 16:33:35 +03:00
Alexey Zakharenkov
5e347b09a1 Recover after 'Item is not in dataset' exception to continue validating other cities 2019-07-02 11:46:27 +03:00
Rolf Eike Beer
9975ecfbad list which subway entrances are not in stop areas 2019-06-22 11:13:27 +02:00
Alexey Zakharenkov
2cd0cf53e4 Rewrite overpass-api request to work (checked to work on rapid modes) 2019-06-06 15:27:20 +03:00
Alexey Zakharenkov
2de5a048d6 Fix spaces; add TODO comment 2019-05-16 22:52:14 +03:00
alexey-zakharenkov
8d179f6b41
Remove traces of working process 2019-04-25 16:58:42 +03:00
Alexey Zakharenkov
d6d6852573 Check for station displacement during recovery station order 2019-04-25 15:24:17 +03:00
Alexey Zakharenkov
e38db5f5be Move io functions into subway_io.py module; a bug fixed 2019-04-25 09:42:48 +03:00
Alexey Zakharenkov
0f83a69f8e Introduce recovery data file; recover 'unsorted stops in route' error 2019-04-23 13:52:35 +03:00
Alexey Zakharenkov
21d0362290 Moved all actions with city cache into a class. This class not only encapsulates the cache logic but also skips cache maintaining in case when --cache command line option is omitted. 2019-03-14 15:27:37 +03:00
Alexey Zakharenkov
b139b1091b Simplify StopArea unique identification 2019-02-01 18:00:05 +03:00
Alexey Zakharenkov
9a94b22145 Remove overriden __hash__ and __eq__ methods for Station and StopArea classes 2019-02-01 01:01:28 +03:00
Alexey Zakharenkov
1d84d6cb38 Replace checking for ZeroDivisionError with checking for minimal distance 2019-01-15 11:14:05 +03:00
Alexey Zakharenkov
814c2accc0 fix the case when two consective points of a way coincide resulting in zero-length track segment and failure of getting projection of a point onto it 2019-01-14 17:49:23 +03:00
Ilya Zverev
06602af71c Reduce entrance errors to warnings 2018-08-02 18:42:46 +03:00
Ilya Zverev
86a95759bc Do not tolerate 0 tram lines 2018-07-25 18:21:39 +03:00
Ilya Zverev
a39cf3232d Support for trams 2018-07-20 19:40:08 +03:00
Ilya Zverev
888bf51f09 Revert entrances warning 2018-04-16 20:15:10 +03:00
Ilya Zverev
599a872c4f Make entrances error a warning 2018-04-15 09:49:24 +03:00
Ilya Zverev
ae6e29fbff Support platform_edge 2018-04-07 14:57:49 +03:00
Ilya Zverev
a3576ec54c Fixed a typo 2018-03-28 14:45:58 +03:00
Ilya Zverev
7a05743a4d Use stations for each lines for validation, fixes #41 2018-03-16 17:29:29 +03:00
Ilya Zverev
8ea7791a4c Fix route 2 in Brussels case 2018-01-26 19:52:10 +03:00