Remove generate-report command in favor of validate-strings-file.

README.md

@@ -29,7 +29,7 @@ Each grouping section contains N string definitions. These string definitions st
 
 ### Tags
 
-Tags are used by Twine as a way to only work with a subset of your strings at any given point in time. Each string can be assigned zero or more tags which are separated by commas. Tags are optional, though highly recommended. You can get a list of all strings currently missing tags by executing the `generate-report` command.
+Tags are used by Twine as a way to only work with a subset of your strings at any given point in time. Each string can be assigned zero or more tags which are separated by commas. Tags are optional, though highly recommended. You can get a list of all strings currently missing tags by executing the `validate-strings-file` command.
 
 ### Whitespace
 
@@ -128,12 +128,6 @@ This command is a convenient way of taking a zip file and executing the `consume
 
 	$ twine consume-loc-drop /path/to/strings.txt LocDrop2.zip
 
-#### `generate-report`
-
-This command gives you useful information about your strings. It will tell you how many strings you have and how many have been translated into each language.
-
-	$ twine generate-report /path/to/strings.txt
-
 #### `validate-strings-file`
 
 This command validates that the strings file can be parsed, contains no duplicate keys, and that all strings have at least one tag. It will exit with a non-zero status code if any of those criteria are not met.

lib/twine/cli.rb

@@ -15,7 +15,7 @@ module Twine
       parser = OptionParser.new do |opts|
         opts.banner = 'Usage: twine COMMAND STRINGS_FILE [INPUT_OR_OUTPUT_PATH] [--lang LANG1,LANG2...] [--tags TAG1,TAG2,TAG3...] [--format FORMAT]'
         opts.separator ''
-        opts.separator 'The purpose of this script is to convert back and forth between multiple data formats, allowing us to treat our strings (and translations) as data stored in a text file. We can then use the data file to create drops for the localization team, consume similar drops returned by the localization team, generate reports on the strings, as well as create formatted string files to ship with your products. Twine currently supports iOS, OS X, Android, gettext, and jquery-localize string files.'
+        opts.separator 'The purpose of this script is to convert back and forth between multiple data formats, allowing us to treat our strings (and translations) as data stored in a text file. We can then use the data file to create drops for the localization team, consume similar drops returned by the localization team, and create formatted string files to ship with your products. Twine currently supports iOS, OS X, Android, gettext, and jquery-localize string files.'
         opts.separator ''
         opts.separator 'Commands:'
         opts.separator ''
@@ -31,8 +31,6 @@ module Twine
         opts.separator ''
         opts.separator 'consume-loc-drop -- Consumes an archive of translated files. This archive should be in the same format as the one created by the generate-loc-drop command.'
         opts.separator ''
-        opts.separator 'generate-report -- Generates a report containing data about your strings. It will tell you how many strings you have and how many of those strings have been translated into each language.'
-        opts.separator ''
         opts.separator 'validate-strings-file -- Validates that the given strings file is parseable, contains no duplicates, and that every string has a tag. Exits with a non-zero exit code if those criteria are not met.'
         opts.separator ''
         opts.separator 'General Options:'
@@ -98,7 +96,6 @@ module Twine
         opts.separator '> twine consume-all-string-files strings.txt Resources/Locales/ --developer-language en --tags DefaultTag1,DefaultTag2'
         opts.separator '> twine generate-loc-drop strings.txt LocDrop5.zip --tags FT,FB --format android --lang de,en,en-GB,ja,ko'
         opts.separator '> twine consume-loc-drop strings.txt LocDrop5.zip'
-        opts.separator '> twine generate-report strings.txt'
         opts.separator '> twine validate-strings-file strings.txt'
       end
       parser.parse! @args
@@ -179,10 +176,6 @@ module Twine
         else
           raise Twine::Error.new 'Not enough arguments.'
         end
-      when 'generate-report'
-        if @args.length > 2
-          raise Twine::Error.new "Unknown argument: #{@args[2]}"
-        end
       when 'validate-strings-file'
         if @args.length > 2
           raise Twine::Error.new "Unknown argument: #{@args[2]}"

lib/twine/runner.rb

@@ -3,7 +3,7 @@ require 'tmpdir'
 Twine::Plugin.new # Initialize plugins first in Runner.
 
 module Twine
-  VALID_COMMANDS = ['generate-string-file', 'generate-all-string-files', 'consume-string-file', 'consume-all-string-files', 'generate-loc-drop', 'consume-loc-drop', 'generate-report', 'validate-strings-file']
+  VALID_COMMANDS = ['generate-string-file', 'generate-all-string-files', 'consume-string-file', 'consume-all-string-files', 'generate-loc-drop', 'consume-loc-drop', 'validate-strings-file']
 
   class Runner
     def initialize(args)
@@ -48,8 +48,6 @@ module Twine
         generate_loc_drop
       when 'consume-loc-drop'
         consume_loc_drop
-      when 'generate-report'
-        generate_report
       when 'validate-strings-file'
         validate_strings_file
       end
@@ -209,30 +207,6 @@ module Twine
       write_strings_data(output_path)
     end
 
-    def generate_report
-      total_strings = 0
-      strings_per_lang = {}
-      @strings.language_codes.each do |code|
-        strings_per_lang[code] = 0
-      end
-
-      @strings.sections.each do |section|
-        section.rows.each do |row|
-          total_strings += 1
-
-          row.translations.each_key do |code|
-            strings_per_lang[code] += 1
-          end
-        end
-      end
-
-      # Print the report.
-      puts "Total number of strings = #{total_strings}"
-      @strings.language_codes.each do |code|
-        puts "#{code}: #{strings_per_lang[code]}"
-      end
-    end
-
     def validate_strings_file
       total_strings = 0
       all_keys = Set.new

test/twine_test.rb

@@ -116,10 +116,6 @@ class TwineTest < Test::Unit::TestCase
     end
   end
 
-  def test_generate_report_1
-    Twine::Runner.run(%w(generate-report test/fixtures/strings-1.txt))
-  end
-
   def test_json_line_breaks_consume
     Dir.mktmpdir do |dir|
       output_path = File.join(dir, 'strings.txt')