organicmaps/twine
Archived
13
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Wiki Activity Actions

Merge pull request #276 from jonasrottmann/fix/android-output-path

Browse source 
Android output path for default language
This commit is contained in:
Sebastian Celis 2019-05-14 14:21:07 -05:00 • committed by GitHub
commit bc4bd7daf0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/twine/formatters/android.rb
View file

@ -41,7 +41,11 @@ module Twine
end
def output_path_for_language(lang)
"values-#{lang}".gsub(/-(\p{Lu})/, '-r\1')
if lang == @twine_file.language_codes[0]
"values"
else
"values-#{lang}".gsub(/-(\p{Lu})/, '-r\1')
end
end
def set_translation_for_key(key, lang, value)

7
test/test_formatters.rb
View file

@ -231,6 +231,13 @@ class TestAndroidFormatter < FormatterTest
def test_output_path_with_region
assert_equal 'values-en-rGB', @formatter.output_path_for_language('en-GB')
end
def test_output_path_respects_default_lang
@formatter.twine_file.language_codes.concat KNOWN_LANGUAGES
non_default_language = KNOWN_LANGUAGES[1..-1].sample
assert_equal 'values', @formatter.output_path_for_language(KNOWN_LANGUAGES[0])
assert_equal "values-#{non_default_language}", @formatter.output_path_for_language(non_default_language)
end
end
class TestAppleFormatter < FormatterTest