Remove validity checks from generate-report

README.md

@@ -130,13 +130,13 @@ This command is a convenient way of taking a zip file and executing the `consume
 
 #### `generate-report`
 
-This command gives you useful information about your strings. It will tell you how many strings you have, how many have been translated into each language, and whether your master strings data file has any duplicate string keys.
+This command gives you useful information about your strings. It will tell you how many strings you have and how many have been translated into each language.
 
 	$ twine generate-report /path/to/strings.txt
 
 #### `validate-strings-file`
 
-This command validates that the strings file can be parsed, contains no duplicate keys, and that all strings have at least one tag. It will exit with a status code other than zero if any of those criteria are not met.
+This command validates that the strings file can be parsed, contains no duplicate keys, and that all strings have at least one tag. It will exit with a non-zero status code if any of those criteria are not met.
 
 	$ twine validate-strings-file /path/to/strings.txt
 

lib/twine/cli.rb

@@ -31,7 +31,7 @@ module Twine
         opts.separator ''
         opts.separator 'consume-loc-drop -- Consumes an archive of translated files. This archive should be in the same format as the one created by the generate-loc-drop command.'
         opts.separator ''
-        opts.separator 'generate-report -- Generates a report containing data about your strings. For example, it will tell you if you have any duplicate strings or if any of your strings are missing tags. In addition, it will tell you how many strings you have and how many of those strings have been translated into each language.'
+        opts.separator 'generate-report -- Generates a report containing data about your strings. It will tell you how many strings you have and how many of those strings have been translated into each language.'
         opts.separator ''
         opts.separator 'validate-strings-file -- Validates that the given strings file is parseable, contains no duplicates, and that every string has a tag. Exits with a non-zero exit code if those criteria are not met.'
         opts.separator ''

lib/twine/runner.rb

@@ -212,9 +212,6 @@ module Twine
     def generate_report
       total_strings = 0
       strings_per_lang = {}
-      all_keys = Set.new
-      duplicate_keys = Set.new
-      keys_without_tags = Set.new
       @strings.language_codes.each do |code|
         strings_per_lang[code] = 0
       end
@@ -223,19 +220,9 @@ module Twine
         section.rows.each do |row|
           total_strings += 1
 
-          if all_keys.include? row.key
-            duplicate_keys.add(row.key)
-          else
-            all_keys.add(row.key)
-          end
-
           row.translations.each_key do |code|
             strings_per_lang[code] += 1
           end
-
-          if row.tags == nil || row.tags.length == 0
-            keys_without_tags.add(row.key)
-          end
         end
       end
 
@@ -244,22 +231,6 @@ module Twine
       @strings.language_codes.each do |code|
         puts "#{code}: #{strings_per_lang[code]}"
       end
-
-      if duplicate_keys.length > 0
-        puts "\nDuplicate string keys:"
-        duplicate_keys.each do |key|
-          puts key
-        end
-      end
-
-      if keys_without_tags.length == total_strings
-        puts "\nNone of your strings have tags."
-      elsif keys_without_tags.length > 0
-        puts "\nStrings without tags:"
-        keys_without_tags.each do |key|
-          puts key
-        end
-      end
     end
 
     def validate_strings_file