organicmaps/twine
Archived
13
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Wiki Activity Actions
287 commits 10 branches 23 tags 1 MiB
Commit graph

88 commits

Author SHA1 Message Date
Sebastian Ludwig
eec7d3b5d2 Logging a warning, if a file is skipped because it would be empty while generating all string files. 2016-02-28 09:18:51 -06:00
Sebastian Ludwig
430bc1bac2 Raising an error if generate_string_file would create an empty file. 2016-02-28 09:14:25 -06:00
Sebastian Ludwig
1e63a89860 Inlined method that was only used once. 2016-02-28 09:14:25 -06:00
Sebastian Ludwig
0f2535223e Removed Abstract::write_file, since formatters should focus on formatting. format_file is used directly instead. 2016-02-27 19:49:01 -06:00
Sebastian Ludwig
3cb766d9a2 Renamed test cases to match the command line option they are testing (--validate). 2016-02-27 17:40:34 -06:00
Sebastian Ludwig
e5f9625105 Fixed typo. 2016-02-27 17:39:15 -06:00
Sebastian Ludwig
0a80890f87 Added more Android formatter language determination unit tests. 2016-02-22 16:31:24 -06:00
Sebastian Ludwig
e2dc6dce01 Fixed Android language determination. Closes #134. 2016-02-22 15:45:11 -06:00
Sebastian Ludwig
9374fdb40a Converted otherwise unused instance variables to local variables. 2016-02-22 09:12:03 -06:00
Sebastian Ludwig
689ad2cd72 Added validate option to validate a strings file before generating any output. 2016-02-22 09:11:04 -06:00
Sebastian Ludwig
1d4e0aeb9b Added pendantic option to validate-strings-file command and hid errors for keys without tags behind it. 2016-02-16 12:54:45 -06:00
Sebastian Celis
662da698ad Merge pull request #129 from sebastianludwig/formatter_refactoring 
Formatter refactoring
 2016-01-19 16:36:18 -06:00
Sebastian Ludwig
b53ecb2be6 Removed initializer parameters from Abstract formatter because they were only used in unit tests. 2016-01-19 13:22:29 -05:00
Sebastian Ludwig
cd055e7021 Changed fixtures to be independent of the gem version. 2016-01-17 20:56:37 -05:00
Sebastian Ludwig
faa896b91b Better way of resetting formatters for every test 2016-01-17 20:53:41 -05:00
Sebastian Ludwig
e4a121ea7d Using instance methods instead of class constants to convey formatter capabilities. 2016-01-17 20:51:40 -05:00
Sebastian Ludwig
c55c7685b9 Storing formatter instances in Twine::Formatters.formatters to make it easier to inject mocks. 2016-01-17 20:47:44 -05:00
Sebastian Celis
faedb5ee78 Merge pull request #125 from sebastianludwig/placeholders 
Improved placeholder handling
 2016-01-12 06:19:54 -06:00
Sebastian Celis
c9a0fd4bc5 Merge pull request #123 from sebastianludwig/no_skip 
Post modularization cleanup
 2016-01-12 06:19:22 -06:00
Sebastian Ludwig
b73045b33b Fixed tests for ruby 1.9. 2015-12-18 13:47:10 +01:00
Sebastian Ludwig
0f9bd0dcba Closed #84 by checking for invalid characters in keys in validate-strings-file. 2015-12-18 13:47:10 +01:00
Sebastian Ludwig
1ecb483dbd Added unit test for validate-strings-file command. 2015-12-18 13:47:10 +01:00
Sebastian Celis
c9aa835621 Merge pull request #122 from sebastianludwig/consume_comments 
Consume comments
 2015-12-17 09:10:13 -06:00
Sebastian Celis
a82c2c99f6 Merge pull request #124 from sebastianludwig/translation_newlines 
Newline escaping
 2015-12-17 09:05:04 -06:00
Sebastian Ludwig
2e0557741b Using Placeholers like a proper module by including it into the Formatters where it's needed. 2015-12-06 15:41:51 +01:00
Sebastian Ludwig
d21f07e735 Re-added @ sign escaping to Android formatter. 2015-12-05 17:12:45 +01:00
Sebastian Ludwig
1a49852a6e Added Placeholders module and added methods to convert from twine format to android and vice versa. 2015-12-05 15:38:33 +01:00
Sebastian Ludwig
1470494525 Moved newline escaping from JQuery formatter to Abstract. 2015-12-05 01:46:17 +01:00
Sebastian Ludwig
69d957fe16 Enabled test. 2015-12-05 01:39:53 +01:00
Sebastian Ludwig
be18757ce7 Moved consume_comments evaluation from concrete formatters to Abstract. Closes #97. 2015-12-05 01:28:26 +01:00
Sebastian Ludwig
00d2dc953e Tested and fixed comment consumption for all formatters. 2015-12-05 01:23:50 +01:00
Sebastian Ludwig
a5a970f12d Added variables for STDOUT and STDERR to be able to redirect the output in unit tests. 2015-12-04 23:22:10 +01:00
Sebastian Celis
b2b4bdcc8a Fix broken unit tests in Ruby < 2.0. 2015-11-29 12:08:41 -06:00
Sebastian Celis
48511652c7 Merge pull request #118 from sebastianludwig/fixed_unit_tests 
Fixed unit tests.
 2015-11-29 11:52:48 -06:00
Sebastian Ludwig
cc282757bb Fixed unit tests. 2015-11-29 18:50:35 +01:00
Sebastian Celis
b8291de63c Merge pull request #112 from sebastianludwig/formatter_modularization_v2 
Formatter modularization v2
 2015-11-29 11:49:04 -06:00
Sebastian Celis
92e869b065 Merge pull request #114 from sebastianludwig/cli_refactoring 
CLI refactoring
 2015-11-29 11:34:02 -06:00
Sebastian Ludwig
c97e94acbb Implemented CLI unit tests. 2015-11-29 17:10:54 +01:00
Sebastian Ludwig
b803deec9f Untangled CLI and Runner. 2015-11-29 17:10:46 +01:00
Sebastian Ludwig
ba4b69baf2 Added unit tests for loc drop generation and consumption. 2015-11-29 17:04:44 +01:00
Sebastian Celis
c5286a4979 Merge pull request #111 from sebastianludwig/command_test_case_cleanup 
Cleaned up CommandTestCase.
 2015-11-29 10:59:02 -05:00
Sebastian Ludwig
7691068e05 Changed header formatting to be optional for formatters. 2015-11-28 15:02:26 +01:00
Sebastian Ludwig
f8d1df554d Adapted JQuery formatter to the modular style. 2015-11-28 14:52:15 +01:00
Sebastian Ludwig
a7ac82aab7 Adapted Gettext formatter to the modular style. 2015-11-28 14:37:30 +01:00
Sebastian Ludwig
a35107ea99 Adapted Flash formatter to the modular style. 2015-11-28 14:37:30 +01:00
Sebastian Ludwig
84cf07d353 Adapted Django formatter to the modular style. 2015-11-28 14:37:30 +01:00
Sebastian Ludwig
bcb6dd928e Added unit tests for Django and Flash formatters. 2015-11-28 13:31:39 +01:00
Sebastian Ludwig
17d206f7ce Changed TestCrateFolders to be a CommandTestCase and renamed it to TestGenerateAllStringFiles. 2015-11-28 01:18:39 +01:00
Sebastian Ludwig
559360977c Cleaned up CommandTestCase. The strings file used by Runner is now injectable which eliminates the need to mock StringsFile.new (which could lead to an infinite loop). 2015-11-27 19:29:50 +01:00
Sebastian Ludwig
1153d8c247 Using set_translation_for_key in JQuery formatter to transform the value instead of read_file. 2015-11-27 15:45:45 +01:00