Remove Apple unnecessary empty lines

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>

lib/twine/formatters/abstract.rb

@@ -103,7 +103,7 @@ module Twine
 
         header = format_header(lang)
         result = ""
-        result += header if header
+        result += header + "\n" if header
         result += format_sections(processed_twine_file, lang)
       end
 
@@ -130,7 +130,7 @@ module Twine
 
         if section.name && section.name.length > 0
           section_header = format_section_header(section)
-          result += "#{section_header}" if section_header
+          result += "\n#{section_header}" if section_header
         end
 
         definitions.map! { |definition| format_definition(definition, lang) }

lib/twine/formatters/android.rb

@@ -96,11 +96,11 @@ module Twine
       end
 
       def format_header(lang)
-        "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n"
+        "<?xml version=\"1.0\" encoding=\"utf-8\"?>"
       end
 
       def format_sections(twine_file, lang)
-        result = "<resources>\n"
+        result = '<resources>'
         
         result += super + "\n"
 
@@ -196,14 +196,6 @@ module Twine
         value.gsub(/\A *| *\z/) { |spaces| '\u0020' * spaces.length }
       end
 
-      def should_include_definition(definition, lang)
-        if definition.is_plural?
-          return !definition.plural_translation_for_lang(lang).nil?
-        else
-          return !definition.translation_for_lang(lang).nil?
-        end
-      end
-
     end
   end
 end

lib/twine/formatters/apple.rb

@@ -65,17 +65,13 @@ module Twine
         end
       end
 
-      def format_footer(lang)
-        "\n"
-      end
-
       def format_file(lang)
         result = super
-        result += format_footer(lang)
+        result += "\n"
       end
 
       def format_section_header(section)
-        "\n\n/********** #{section.name} **********/"
+        "\n/********** #{section.name} **********/\n"
       end
 
       def key_value_pattern

lib/twine/formatters/apple_plural.rb

@@ -18,7 +18,12 @@ module Twine
       end
 
       def format_footer(lang)
-        footer = "\n</dict>\n</plist>\n"
+        footer = "</dict>\n</plist>"
+      end
+
+      def format_file(lang)
+        result = super
+        result += format_footer(lang)
       end
 
       def format_header(lang)
@@ -28,6 +33,7 @@ module Twine
       end
 
       def format_section_header(section)
+        "<!-- ********** #{section.name} **********/ -->\n"
       end
 
       def format_plural_keys(key, plural_hash)
@@ -45,7 +51,7 @@ module Twine
         result += plural_hash.map{|quantity,value| "\t\t\t<key>#{quantity}</key>\n\t\t\t<string>#{convert_placeholders_from_android_to_twine(value)}</string>"}.join("\n")
         result += "\n"
         result += "\t\t</dict>\n"
-        result += "\t</dict>"
+        result += "\t</dict>\n"
       end
 
       def format_comment(definition, lang)

lib/twine/output_processor.rb

@@ -50,8 +50,8 @@ module Twine
 
             if definition.is_plural?
               # If definition is plural, but no translation found -> create
-              # and add 'other' key
-              if (new_definition.plural_translations[language] ||= {}).empty?
+              # Then check 'other' key
+              if !(new_definition.plural_translations[language] ||= {}).key? 'other'
                 new_definition.plural_translations[language]['other'] = value
               end
             end

lib/twine/twine_file.rb

@@ -213,34 +213,25 @@ module Twine
           f.puts "[[#{section.name}]]"
 
           section.definitions.each do |definition|
-            f.puts "\n#{space(2)}[#{definition.key}]"
-
-            if definition.raw_comment and definition.raw_comment.length > 0
-              f.puts "#{space(4)}comment = #{definition.raw_comment}"
-            end
-            if definition.tags && definition.tags.length > 0
-              tag_str = definition.tags.join(',')
-              f.puts "#{space(4)}tags = #{tag_str}"
-            end
-            if definition.reference_key
-              f.puts "#{space(4)}ref = #{definition.reference_key}"
-            end
+            f.puts "\t[#{definition.key}]"
 
             value = write_value(definition, dev_lang, f)
             if !value && !definition.reference_key
               Twine::stdout.puts "WARNING: #{definition.key} does not exist in developer language '#{dev_lang}'"
             end
-
-            @language_codes[1..-1].each do |lang|
-              if lang =~ /^#{dev_lang}/
-                write_value(definition, lang, f)
-              end
+            
+            if definition.reference_key
+              f.puts "\t\tref = #{definition.reference_key}"
+            end
+            if definition.tags && definition.tags.length > 0
+              tag_str = definition.tags.join(',')
+              f.puts "\t\ttags = #{tag_str}"
+            end
+            if definition.raw_comment and definition.raw_comment.length > 0
+              f.puts "\t\tcomment = #{definition.raw_comment}"
             end
-
             @language_codes[1..-1].each do |lang|
-              if not lang =~ /^#{dev_lang}/
-                write_value(definition, lang, f)
-              end
+              write_value(definition, lang, f)
             end
           end
         end
@@ -257,14 +248,9 @@ module Twine
         value = '`' + value + '`'
       end
 
-      file.puts "#{space(4)}#{language} = #{value}"
+      file.puts "\t\t#{language} = #{value}"
       return value
     end
 
-    def space(level)
-        ' ' * level
-    end
-
-
   end
 end