organicmaps/website
13
Fork 1
Code Issues 31 Pull requests 8 Projects Releases Wiki Activity Actions

Embedded faq #246

Merged
root merged 10 commits from embedded-faq into master 2024-07-31 10:29:00 +00:00
Conversation 5 Commits 10 Files changed 4 +243 -1
strump commented 2024-07-15 08:17:23 +00:00
Member
Copy link

Added Zola template to generate FAQ simmilar to https://github.com/organicmaps/organicmaps/blob/master/data/faq.html

See /faq/embedded-faq?lang=en, or /faq/embedded-faq?lang=pl, or /faq/embedded-faq?lang=ru, etc.

Problem 1: there are no questions "How to create a route and start navigation" and "I can't hear voice instructions" in https://organicmaps.app/faq/

Added two more questions to master branch and to embedded FAQ page.

Problem 2: New strings "For more information please visit our web-site" and "Go to Top" should be translated in config.toml but I just put HTML code with translations into embedded-faq.html.

Added two strings more-info-om and go-to-top to translations list.

FAQ looks and works good in Android and iOS:

Added Zola template to generate FAQ simmilar to https://github.com/organicmaps/organicmaps/blob/master/data/faq.html See [`/faq/embedded-faq?lang=en`](https://embedded-faq.organicmaps.pages.dev/faq/embedded-faq/?lang=en), or [`/faq/embedded-faq?lang=pl`](https://embedded-faq.organicmaps.pages.dev/faq/embedded-faq/?lang=pl), or [`/faq/embedded-faq?lang=ru`](https://embedded-faq.organicmaps.pages.dev/faq/embedded-faq/?lang=ru), etc. <s>**Problem 1:** there are no questions "How to create a route and start navigation" and "I can't hear voice instructions" in https://organicmaps.app/faq/</s> Added two more questions to `master` branch and to embedded FAQ page. <s>**Problem 2:** New strings "For more information please visit our web-site" and "Go to Top" should be translated in config.toml but I just put HTML code with translations into `embedded-faq.html`.</s> Added two strings `more-info-om` and `go-to-top` to translations list. FAQ looks and works good in Android and iOS: <img width="300" src="https://github.com/user-attachments/assets/eed3e9d4-5f10-457e-b07e-f6d85e19c567"/> <img width="300" src="https://github.com/user-attachments/assets/fc9fd522-476c-4975-a0ff-7033eecc3b59"/> <img width="300" src="https://github.com/user-attachments/assets/817bb28d-755f-4a2e-b753-58726b9bf0ea"/>
biodranik commented 2024-07-15 16:09:36 +00:00 (Migrated from github.com)
Copy link

There is a non-matching p tag:

выява
There is a non-matching p tag: <img width="1417" alt="выява" src="https://github.com/user-attachments/assets/ed829a7f-2b9c-4697-b381-722bc8a1e37c">
cloudflare-workers-and-pages[bot] commented 2024-07-15 16:21:08 +00:00 (Migrated from github.com)
Copy link

Deploying organicmaps with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1eaea3d
Status: ✅  Deploy successful!
Preview URL: https://5c804780.organicmaps.pages.dev
Branch Preview URL: https://embedded-faq.organicmaps.pages.dev

View logs

## Deploying organicmaps with &nbsp;<a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> &nbsp;Cloudflare Pages <table><tr><td><strong>Latest commit:</strong> </td><td> <code>1eaea3d</code> </td></tr> <tr><td><strong>Status:</strong></td><td>&nbsp;✅&nbsp; Deploy successful!</td></tr> <tr><td><strong>Preview URL:</strong></td><td> <a href='https://5c804780.organicmaps.pages.dev'>https://5c804780.organicmaps.pages.dev</a> </td></tr> <tr><td><strong>Branch Preview URL:</strong></td><td> <a href='https://embedded-faq.organicmaps.pages.dev'>https://embedded-faq.organicmaps.pages.dev</a> </td></tr> </table> [View logs](https://dash.cloudflare.com/?to=/:account/pages/view/organicmaps/5c804780-b0d5-47be-9642-e78ccf24c56d)
strump commented 2024-07-15 16:22:29 +00:00
Author
Member
Copy link

@biodranik this error is caused by <ul> tag within <p> tag. So I removed outer <p> tag. Anyway Markdown-to-HTML convertor adds those tags automatically

@biodranik this error is caused by `<ul>` tag within `<p>` tag. So I removed outer `<p>` tag. Anyway Markdown-to-HTML convertor adds those tags automatically
biodranik (Migrated from github.com) reviewed 2024-07-15 17:07:07 +00:00
biodranik (Migrated from github.com) left a comment
Copy link

Thanks a lot for this PR!

there are no questions "How to create a route and start navigation" and "I can't hear voice instructions"

Why? What is needed to fix it?

Thanks a lot for this PR! > there are no questions "How to create a route and start navigation" and "I can't hear voice instructions" Why? What is needed to fix it?
content/faq/embedded-faq.md
@ -0,0 +1,7 @@
---
title: Multilang single page FAQ
biodranik (Migrated from github.com) commented 2024-07-15 16:55:30 +00:00
Copy link

Would it be better to index it with search engines or not index it?

Would it be better to index it with search engines or not index it?
templates/faq/embedded-faq.html
biodranik (Migrated from github.com) commented 2024-07-15 16:58:05 +00:00
Copy link

Is it possible to avoid manual adding of these pages?

Is it possible to avoid manual adding of these pages?
biodranik (Migrated from github.com) commented 2024-07-15 16:58:40 +00:00
Copy link

Is it possible to generate this list automatically?

Is it possible to generate this list automatically?
biodranik (Migrated from github.com) commented 2024-07-15 16:58:56 +00:00
Copy link
        // Show Russian for browsers with these language codes.
```suggestion // Show Russian for browsers with these language codes. ```
biodranik (Migrated from github.com) commented 2024-07-15 16:59:07 +00:00
Copy link
        // TODO: Update this list with new translations.
```suggestion // TODO: Update this list with new translations. ```
biodranik (Migrated from github.com) commented 2024-07-15 16:59:24 +00:00
Copy link

Can it be automatically updated?

Can it be automatically updated?
biodranik (Migrated from github.com) commented 2024-07-15 17:01:04 +00:00
Copy link
        <a href="https://organicmaps.app/de/">organicmaps.app/de/</a>
```suggestion <a href="https://organicmaps.app/de/">organicmaps.app/de/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:01:11 +00:00
Copy link
        <a href="https://organicmaps.app/ru/">organicmaps.app/ru/</a>
```suggestion <a href="https://organicmaps.app/ru/">organicmaps.app/ru/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:01:23 +00:00
Copy link
        <a href="https://organicmaps.app/es/">organicmaps.app/es/</a>
```suggestion <a href="https://organicmaps.app/es/">organicmaps.app/es/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:01:45 +00:00
Copy link
        <a href="https://organicmaps.app/fr/">organicmaps.app/fr/</a>
```suggestion <a href="https://organicmaps.app/fr/">organicmaps.app/fr/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:02:10 +00:00
Copy link
        <a href="https://organicmaps.app/pt/">organicmaps.app/pt/</a>
```suggestion <a href="https://organicmaps.app/pt/">organicmaps.app/pt/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:02:22 +00:00
Copy link
        <a href="https://organicmaps.app/pt-BR/">organicmaps.app/pt-BR/</a>
```suggestion <a href="https://organicmaps.app/pt-BR/">organicmaps.app/pt-BR/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:02:31 +00:00
Copy link
        <a href="https://organicmaps.app/pl/">organicmaps.app/pl/</a>.
```suggestion <a href="https://organicmaps.app/pl/">organicmaps.app/pl/</a>. ```
biodranik (Migrated from github.com) commented 2024-07-15 17:02:43 +00:00
Copy link
        <a href="https://organicmaps.app/uk/">organicmaps.app/uk/</a>
```suggestion <a href="https://organicmaps.app/uk/">organicmaps.app/uk/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:03:06 +00:00
Copy link
        <a href="https://organicmaps.app/zh-Hans/">organicmaps.app/zh-Hans/</a>
```suggestion <a href="https://organicmaps.app/zh-Hans/">organicmaps.app/zh-Hans/</a> ```
biodranik (Migrated from github.com) commented 2024-07-15 17:04:47 +00:00
Copy link

Is it possible to have one dd section for all translations inside it? E.g. dd with a div+lang or p+lang inside?

Is it possible to have one dd section for all translations inside it? E.g. dd with a div+lang or p+lang inside?
biodranik (Migrated from github.com) commented 2024-07-15 17:05:59 +00:00
Copy link

Looks like adding these translations into config.toml would be more flexible.

Looks like adding these translations into config.toml would be more flexible.
templates/faq/embedded-faq.html
@ -0,0 +137,4 @@
<div class="faq">
<h2 lang="en">FAQ</h2>
<h2 lang="ru">Часто задаваемые вопросы (FAQ)</h2>
biodranik (Migrated from github.com) commented 2024-07-15 16:59:54 +00:00
Copy link

Is it possible to extract titles/translations from related pages?

Is it possible to extract titles/translations from related pages?
strump reviewed 2024-07-25 20:39:34 +00:00
content/faq/embedded-faq.md
@ -0,0 +1,7 @@
---
title: Multilang single page FAQ
strump commented 2024-07-25 20:39:34 +00:00
Author
Member
Copy link

This page has the same content as other FAQ pages. I think we don't need to index it by sesarch engines.

This page has the same content as other FAQ pages. I think we don't need to index it by sesarch engines.
strump reviewed 2024-07-25 20:41:48 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:41:48 +00:00
Author
Member
Copy link

We export only subset of FAQ questions. How can we tell which pages to include? Does ordering matters?

We export only subset of FAQ questions. How can we tell which pages to include? Does ordering matters?
strump reviewed 2024-07-25 20:42:57 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:42:57 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:18 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:18 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:23 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:23 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:27 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:27 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:31 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:31 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:35 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:34 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:39 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:39 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:42 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:42 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:43:47 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:43:47 +00:00
Author
Member
Copy link

I used for-loop to generate links in format organicmaps.app/{{ lang }}/

I used for-loop to generate links in format `organicmaps.app/{{ lang }}/`
strump reviewed 2024-07-25 20:44:15 +00:00
templates/faq/embedded-faq.html
strump commented 2024-07-25 20:44:15 +00:00
Author
Member
Copy link

Added new translation key 'go-to-top'.

Added new translation key 'go-to-top'.
biodranik (Migrated from github.com) reviewed 2024-07-29 19:20:04 +00:00
content/faq/embedded-faq.md
@ -0,0 +1,7 @@
---
title: Multilang single page FAQ
biodranik (Migrated from github.com) commented 2024-07-29 19:20:04 +00:00
Copy link

Does it have <meta name="robots" content="noindex" /> in the template?

Does it have `<meta name="robots" content="noindex" />` in the template?
biodranik commented 2024-07-29 20:53:51 +00:00 (Migrated from github.com)
Copy link

@strump can you please double-check if it's ready to merge and if the produced html works on iOS and Android?

@strump can you please double-check if it's ready to merge and if the produced html works on iOS and Android?
👀 1
strump commented 2024-07-30 10:34:22 +00:00
Author
Member
Copy link

@biodranik ready to merge

@biodranik ready to merge
biodranik (Migrated from github.com) approved these changes 2024-07-31 10:28:53 +00:00
biodranik (Migrated from github.com) left a comment
Copy link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
biodranik
Labels
Clear labels   
about page

About Page of the website

  
bug

Something isn't working

  
community page

Community Page of the website

  
documentation

Improvements or additions to documentation

  
donate page

Donate Page of the website

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature page

Feature Page of the website

  
good first issue

Good for newcomers

  
Google Season of Docs

Google Season of Docs

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
landing page

Landing Page of website

  
news page

News Page of the website

  
question

Further information is requested

  
support page

Support Page of the website

  
wontfix

This will not be worked on

No labels
about page
bug
community page
documentation
donate page
duplicate
enhancement
feature page
good first issue
Google Season of Docs
help wanted
invalid
landing page
news page
question
support page
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/website#246
No description provided.
Delete branch "embedded-faq"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?