organicmaps/website
13
Fork 1
Code Issues 31 Pull requests 8 Projects Releases Wiki Activity Actions

[WIP]Added text to speech instructions #32

Closed
vachan-maker wants to merge 13 commits from master into master
pull from: master
merge into: organicmaps:master
Conversation 10 Commits 13 Files changed 4 +52
vachan-maker commented 2022-04-20 15:35:05 +00:00 (Migrated from github.com)
Copy link

organicmaps/organicmaps#2383

Still working on it.

https://git.omaps.dev/organicmaps/organicmaps/issues/2383 Still working on it.
👍 1
biodranik (Migrated from github.com) reviewed 2022-04-20 15:35:05 +00:00
vachan-maker commented 2022-04-20 15:54:32 +00:00 (Migrated from github.com)
Copy link

Hmm..I forgot to add signed off

Hmm..I forgot to add signed off
biodranik commented 2022-04-20 16:58:28 +00:00 (Migrated from github.com)
Copy link

Thanks! Do you have other devices to take more different screenshots for different Android versions?
@pastk can you help?

Thanks! Do you have other devices to take more different screenshots for different Android versions? @pastk can you help?
biodranik commented 2022-04-20 17:08:55 +00:00 (Migrated from github.com)
Copy link

It makes sense to provide instructions for different versions of Android, and also some hints on where users can install a proper TTS engine. Some hints can be extracted from existing TTS issues: https://github.com/organicmaps/organicmaps/issues?q=is%3Aissue+tts+

It makes sense to provide instructions for different versions of Android, and also some hints on where users can install a proper TTS engine. Some hints can be extracted from existing TTS issues: https://github.com/organicmaps/organicmaps/issues?q=is%3Aissue+tts+
vachan-maker commented 2022-04-20 17:28:07 +00:00 (Migrated from github.com)
Copy link

No, I don't have any other devices. Yes, I will add the instructions from where users can add a tts engine.

No, I don't have any other devices. Yes, I will add the instructions from where users can add a tts engine.
pastk commented 2022-04-21 17:52:22 +00:00
Owner
Copy link

Thanks! Do you have other devices to take more different screenshots for different Android versions? @pastk can you help?

I have a custom a9.0 and a5.0 emulator only.

I doubt its reasonable to include screenshots for many versions of vendorized settings layouts. Probably its better to describe (and illustrate with screenshots) a single universal way of using a "Text-to-speech" search to locate the settings.

> Thanks! Do you have other devices to take more different screenshots for different Android versions? @pastk can you help? I have a custom a9.0 and a5.0 emulator only. I doubt its reasonable to include screenshots for many versions of vendorized settings layouts. Probably its better to describe (and illustrate with screenshots) a single universal way of using a "Text-to-speech" search to locate the settings.
vachan-maker commented 2022-04-28 15:10:13 +00:00 (Migrated from github.com)
Copy link

These instructions are from Google

https://support.google.com/accessibility/android/answer/6006983?hl=en

They have only listed one method

These instructions are from Google https://support.google.com/accessibility/android/answer/6006983?hl=en They have only listed one method
vachan-maker commented 2022-05-26 01:36:35 +00:00 (Migrated from github.com)
Copy link

Added instructions for text to speech on Lineage OS

Added instructions for text to speech on Lineage OS
👍 1
biodranik (Migrated from github.com) reviewed 2022-05-26 17:38:40 +00:00
content/text-to-speech.md
@ -0,0 +31,4 @@
Often RHVoice doesn't get initialized properly and app itself might be crashing. Mostly in cases where you haven't used any TTS engine on your phone yet (new installations etc)
If you use custom rom like Lineageos without Google Play services & Speech Services by Google and want to use RHVoice as your preferred TTS engine, please follow workaround instructions below:
biodranik (Migrated from github.com) commented 2022-05-26 17:38:40 +00:00
Copy link

This is a markdown, you can make a numbered list.

This is a markdown, you can make a numbered list.
vachan-maker (Migrated from github.com) reviewed 2022-05-28 15:04:42 +00:00
content/text-to-speech.md
@ -0,0 +31,4 @@
Often RHVoice doesn't get initialized properly and app itself might be crashing. Mostly in cases where you haven't used any TTS engine on your phone yet (new installations etc)
If you use custom rom like Lineageos without Google Play services & Speech Services by Google and want to use RHVoice as your preferred TTS engine, please follow workaround instructions below:
vachan-maker (Migrated from github.com) commented 2022-05-28 15:04:42 +00:00
Copy link

Is this enough?

Is this enough?
rtsisyk approved these changes 2022-09-06 08:20:30 +00:00
rtsisyk left a comment
Owner
Copy link

LGTM

LGTM
foss- (Migrated from github.com) reviewed 2022-09-06 08:58:29 +00:00
content/text-to-speech.md
@ -0,0 +31,4 @@
Often RHVoice doesn't get initialized properly and app itself might be crashing. Mostly in cases where you haven't used any TTS engine on your phone yet (new installations etc)
If you use custom rom like Lineageos without Google Play services & Speech Services by Google and want to use RHVoice as your preferred TTS engine, please follow workaround instructions below:
foss- (Migrated from github.com) commented 2022-09-06 08:58:29 +00:00
Copy link

It's LineageOS, see https://lineageos.org/ or https://github.com/lineageos

It's `LineageOS`, see https://lineageos.org/ or https://github.com/lineageos
rtsisyk commented 2022-09-08 05:53:36 +00:00
Owner
Copy link

Hi @vachan-maker , sorry for not getting back to you sooner on this PR. Let's merge it and move forward. I need two things:

  1. Fix zola serve
Error: Reason: Variable `alt` not found in context while rendering 'shortcodes/screenshot.html'
  1. Add Signed-off-by (git commit --amend -s)

https://github.com/organicmaps/organicmaps/blob/master/docs/CONTRIBUTING.md#submitting-your-changes

I promise that we will move forward faster with reviews. This repo just wasn't on my radar.
The further plan is to integrate FAQ from the app (in main repo) and rework the build process to get the generated version from website when building the app.

Hi @vachan-maker , sorry for not getting back to you sooner on this PR. Let's merge it and move forward. I need two things: 1. Fix `zola serve` ``` Error: Reason: Variable `alt` not found in context while rendering 'shortcodes/screenshot.html' ``` 2. Add Signed-off-by (git commit --amend -s) https://github.com/organicmaps/organicmaps/blob/master/docs/CONTRIBUTING.md#submitting-your-changes I promise that we will move forward faster with reviews. This repo just wasn't on my radar. The further plan is to integrate FAQ from the app (in main repo) and rework the build process to get the generated version from website when building the app.
vachan-maker commented 2023-11-12 08:26:15 +00:00 (Migrated from github.com)
Copy link

Hi I am really sorry for not completing this.
Is this PR still required? Or should I close it?

Hi I am really sorry for not completing this. Is this PR still required? Or should I close it?
meenbeese commented 2023-11-17 19:17:11 +00:00 (Migrated from github.com)
Copy link

Hi I am really sorry for not completing this.
Is this PR still required? Or should I close it?

We appreciate your initial work and are close to finishing it in #171 and #185. Therefore, it makes sense to close this PR in favor of those, where you can review the work and contribute your ideas instead. @vachan-maker

> Hi I am really sorry for not completing this. > Is this PR still required? Or should I close it? We appreciate your initial work and are close to finishing it in #171 and #185. Therefore, it makes sense to close this PR in favor of those, where you can review the work and contribute your ideas instead. @vachan-maker
👍 1

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
biodranik
rtsisyk
Labels
Clear labels   
about page

About Page of the website

  
bug

Something isn't working

  
community page

Community Page of the website

  
documentation

Improvements or additions to documentation

  
donate page

Donate Page of the website

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
feature page

Feature Page of the website

  
good first issue

Good for newcomers

  
Google Season of Docs

Google Season of Docs

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
landing page

Landing Page of website

  
news page

News Page of the website

  
question

Further information is requested

  
support page

Support Page of the website

  
wontfix

This will not be worked on

No labels
about page
bug
community page
documentation
donate page
duplicate
enhancement
feature page
good first issue
Google Season of Docs
help wanted
invalid
landing page
news page
question
support page
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/website#32
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?