Generic Warning Fixes

anim/value_interpolation.hpp

@@ -9,7 +9,6 @@ namespace anim
   private:
 
     double m_startValue;
-    double m_curValue;
     double & m_outValue;
     double m_endValue;
 

base/commands_queue.cpp

@@ -80,7 +80,7 @@ namespace core
   }
 
   CommandsQueue::Routine::Routine(CommandsQueue * parent, int idx)
-    : m_parent(parent), m_idx(idx), m_env(idx)
+    : m_parent(parent), m_env(idx)
   {}
 
   void CommandsQueue::Routine::Do()

base/commands_queue.hpp

@@ -127,7 +127,6 @@ namespace core
     private:
 
       CommandsQueue * m_parent;
-      int m_idx;
       Environment m_env;
 
     public:

coding/coding_tests/coder_util_test.cpp

@@ -4,14 +4,14 @@
 #include "../coder_util.hpp"
 #include "../../base/logging.hpp"
 
-namespace
-{
-  size_t FixedDstSizeInfiniteMemoryEncode(char const *, size_t, char *, size_t /*dstSize*/)
-  {
-    // LOG(LINFO, ("DstSize", dstSize));
-    return -1U;
-  }
-}
+//namespace
+//{
+//  size_t FixedDstSizeInfiniteMemoryEncode(char const *, size_t, char *, size_t /*dstSize*/)
+//  {
+//    // LOG(LINFO, ("DstSize", dstSize));
+//    return -1U;
+//  }
+//}
 
 /* Commented because takes too much time after memory upgrage :)
 UNIT_TEST(FixedDstSizeCodeToStringInfiniteMemoryTest)

coding/hex.hpp

@@ -48,6 +48,13 @@ inline string NumToHex(IntT n)
   return ToHex(buf, sizeof(buf));
 }
 
+/// Specialization to avoid warnings
+template <>
+inline string NumToHex<char>(char c)
+{
+  return ToHex(&c, sizeof(c));
+}
+
 inline string FromHex(void const * ptr, size_t size) {
   string result;
   result.resize(size / 2);

coding/internal/file_data.hpp

@@ -34,7 +34,6 @@ public:
   string GetName() const { return m_FileName; }
 
 private:
-  uint64_t m_LastAccessPos;
 #ifdef OMIM_OS_BADA
   Osp::Io::File m_File;
 #else

coding/zip_creator.cpp

@@ -47,7 +47,8 @@ bool createZipFromPathDeflatedAndDefaultCompression(string const & filePath, str
   ZipHandle zip(zipFilePath);
   if (!zip.m_zipFile)
     return false;
-  zip_fileinfo zipInfo = { 0 };
+  // Special syntax to initialize struct with zeroes
+  zip_fileinfo zipInfo = zip_fileinfo();
   CreateTMZip(zipInfo.tmz_date);
   string fileName = filePath;
   my::GetNameFromFullPath(fileName);

graphics/path_renderer.cpp

@@ -132,7 +132,7 @@ namespace graphics
   void PathRenderer::drawStipplePath(m2::PointD const * points, size_t pointsCount, double offset, Pen const * pen, double depth)
   {
     bool const hasRoundJoin = (pen->m_info.m_join == pen->m_info.ERoundJoin);
-    bool const hasBevelJoin = (pen->m_info.m_join == pen->m_info.EBevelJoin);
+//    bool const hasBevelJoin = (pen->m_info.m_join == pen->m_info.EBevelJoin);
     bool const hasJoin = (pen->m_info.m_join != pen->m_info.ENoJoin);
 
     float rawTileStartLen = 0;

graphics/path_renderer.hpp

@@ -5,7 +5,7 @@
 
 namespace graphics
 {
-  class Pen;
+  struct Pen;
 
   class PathRenderer : public AreaRenderer
   {

graphics/skin_loader.hpp

@@ -59,19 +59,21 @@ namespace graphics
 /// pointStyle-specific parameters
     string m_resID;
 
+/// skin-page specific parameters
+    string m_fileName;
+
+///
+    shared_ptr<ResourceManager> m_resourceManager;
+
 /// skin-specific parameters
 
     vector<shared_ptr<ResourceCache> > & m_caches;
 
-/// skin-page specific parameters
-    string m_fileName;
 
     typedef list<pair<int32_t, shared_ptr<Resource> > > TResourceList;
 
     TResourceList m_resourceList;
 
-    shared_ptr<ResourceManager> m_resourceManager;
-
   public:
 
     SkinLoader(shared_ptr<ResourceManager> const & resourceManager,

graphics/text_renderer.cpp

@@ -13,12 +13,11 @@
 namespace graphics
 {
   TextRenderer::Params::Params()
-    : m_drawTexts(true)
+//    : m_drawTexts(true)
   {}
 
   TextRenderer::TextRenderer(Params const & params)
-    : base_t(params),
-      m_drawTexts(params.m_drawTexts)
+    : base_t(params)//, m_drawTexts(params.m_drawTexts)
   {}
 
   void TextRenderer::drawStraightGlyph(m2::PointD const & ptPivot,

graphics/text_renderer.hpp

@@ -18,17 +18,17 @@ namespace graphics
   {
   private:
 
-    bool m_drawTexts;
+//    bool m_drawTexts;
 
   public:
 
     typedef ImageRenderer base_t;
 
-    struct Params : base_t::Params
-    {
-      bool m_drawTexts;
-      Params();
-    };
+//    struct Params : base_t::Params
+//    {
+//      bool m_drawTexts;
+//      Params();
+//    };
 
     TextRenderer(Params const & params);
 

map/draw_processor.hpp

@@ -178,8 +178,6 @@ namespace get_pts
     double m_startLength;
     double m_endLength;
 
-    double m_fontSize;
-
     void StartPL(m2::PointD const & pt);
     void EndPL();
 

map/navigator.cpp

@@ -168,7 +168,7 @@ ScreenBase const Navigator::ShrinkInto(ScreenBase const & screen, m2::RectD boun
 
 bool Navigator::CanRotateInto(ScreenBase const & screen, m2::RectD const & boundRect)
 {
-  m2::RectD clipRect = screen.ClipRect();
+//  m2::RectD clipRect = screen.ClipRect();
   //@TODO
   return false;
 }

search/params.cpp

@@ -43,10 +43,9 @@ bool SearchParams::IsEqualCommon(SearchParams const & rhs) const
 
 string DebugPrint(SearchParams const & params)
 {
-  string s = ("search::SearchParams: ");
-  s += "Query = " + params.m_query;
-  s += "Mode = " + params.m_searchMode;
-  return s;
+  ostringstream stream;
+  stream << "search::SearchParams: Query = " << params.m_query << " Mode = " << params.m_searchMode;
+  return stream.str();
 }
 
 } // namespace search

search/search_engine.cpp

@@ -76,7 +76,6 @@ Engine::Engine(IndexType const * pIndex, Reader * pCategoriesR,
                ModelReaderPtr polyR, ModelReaderPtr countryR,
                string const & lang)
   : m_readyThread(false),
-    m_pIndex(pIndex),
     m_pData(new EngineData(pCategoriesR, polyR, countryR))
 {
   InitSuggestions doInit;

search/search_engine.hpp

@@ -71,7 +71,6 @@ private:
   SearchParams m_params;
   m2::RectD m_viewport;
 
-  Index const * m_pIndex;
   scoped_ptr<search::Query> m_pQuery;
   scoped_ptr<EngineData> m_pData;
 };