From 021ddcc1035522a7b55f13c301ede39a7d6ad989 Mon Sep 17 00:00:00 2001 From: Dmitry Yunitsky Date: Tue, 17 Feb 2015 15:38:39 +0300 Subject: [PATCH] Bookmark refactoring & adaptation for new PP. --- .../mapswithme/test/MonkeyEventsReceiver.java | 11 +- android/res/layout/add_or_edit_bookmark.xml | 6 +- android/res/layout/buttons_place_page.xml | 14 +- android/res/layout/color_row.xml | 31 +- android/res/layout/details_place_page.xml | 48 ++- android/res/layout/fragment_color_grid.xml | 8 + android/res/values/styles.xml | 7 +- .../src/com/mapswithme/maps/MWMActivity.java | 31 +- .../com/mapswithme/maps/MWMApplication.java | 2 +- .../AbstractBookmarkCategoryAdapter.java | 11 +- .../maps/bookmarks/BookmarkActivity.java | 2 +- .../bookmarks/BookmarkCategoriesAdapter.java | 4 +- .../bookmarks/BookmarkCategoriesFragment.java | 4 +- .../maps/bookmarks/BookmarkListAdapter.java | 2 +- .../maps/bookmarks/BookmarksListFragment.java | 15 +- .../ChooseBookmarkCategoryFragment.java | 4 +- .../maps/bookmarks/IconsAdapter.java | 42 +-- .../maps/bookmarks/data/Bookmark.java | 11 +- .../bookmarks/data/BookmarkIconManager.java | 27 -- .../maps/bookmarks/data/BookmarkManager.java | 43 +-- .../mapswithme/maps/bookmarks/data/Icon.java | 30 +- .../BookmarkColorDialogFragment.java | 83 ++++++ .../maps/widget/placepage/PlacePageView.java | 275 ++++++++---------- .../util/statistics/Statistics.java | 5 +- .../maps/tests/MapObjectActivityBMKTest.java | 2 +- 25 files changed, 387 insertions(+), 331 deletions(-) create mode 100644 android/res/layout/fragment_color_grid.xml delete mode 100644 android/src/com/mapswithme/maps/bookmarks/data/BookmarkIconManager.java create mode 100644 android/src/com/mapswithme/maps/widget/placepage/BookmarkColorDialogFragment.java diff --git a/android/MapsWithMeTest/src/com/mapswithme/test/MonkeyEventsReceiver.java b/android/MapsWithMeTest/src/com/mapswithme/test/MonkeyEventsReceiver.java index 53546ec4ca..2a620b751e 100644 --- a/android/MapsWithMeTest/src/com/mapswithme/test/MonkeyEventsReceiver.java +++ b/android/MapsWithMeTest/src/com/mapswithme/test/MonkeyEventsReceiver.java @@ -117,14 +117,13 @@ public class MonkeyEventsReceiver extends BroadcastReceiver @Override public boolean run(final MWMActivity target) { - final BookmarkManager bmkManager = BookmarkManager.getBookmarkManager(); - final int categoriesCount = bmkManager.getCategoriesCount(); + final int categoriesCount = BookmarkManager.INSTANCE.getCategoriesCount(); // find category BookmarkCategory categoryToShow = null; for (int i = 0; i < categoriesCount; i++) { - categoryToShow = bmkManager.getCategoryById(i); + categoryToShow = BookmarkManager.INSTANCE.getCategoryById(i); if (categoryToShow.getName().contains(mName)) break; else @@ -159,12 +158,12 @@ public class MonkeyEventsReceiver extends BroadcastReceiver // bring foreground mActivity.startActivity(new Intent(mActivity, MWMActivity.class)); - final Bookmark bookmark = bmkManager.getBookmark(mCatId, mBmkId); - final BookmarkCategory category = bmkManager.getCategoryById(mCatId); + final Bookmark bookmark = BookmarkManager.INSTANCE.getBookmark(mCatId, mBmkId); + final BookmarkCategory category = BookmarkManager.INSTANCE.getCategoryById(mCatId); final String desc = bookmark.getBookmarkDescription(); // Center camera at bookmark - bmkManager.showBookmarkOnMap(mCatId, mBmkId); + BookmarkManager.INSTANCE.showBookmarkOnMap(mCatId, mBmkId); // N2DP (Nataha to Dmitry Protocol) // Bookmark has no description: show map diff --git a/android/res/layout/add_or_edit_bookmark.xml b/android/res/layout/add_or_edit_bookmark.xml index 1e7dbe2140..d2737c3909 100644 --- a/android/res/layout/add_or_edit_bookmark.xml +++ b/android/res/layout/add_or_edit_bookmark.xml @@ -43,7 +43,7 @@ diff --git a/android/res/layout/buttons_place_page.xml b/android/res/layout/buttons_place_page.xml index 4cd15055f5..147b3ccc65 100644 --- a/android/res/layout/buttons_place_page.xml +++ b/android/res/layout/buttons_place_page.xml @@ -93,13 +93,6 @@ android:scaleType="center" android:src="@drawable/ic_bookmark_off"/> - - + + + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:background="?attr/clickableBackground" + android:padding="@dimen/margin_small"> - - - + \ No newline at end of file diff --git a/android/res/layout/details_place_page.xml b/android/res/layout/details_place_page.xml index 2b03cd5cd6..b55e6cc9f7 100644 --- a/android/res/layout/details_place_page.xml +++ b/android/res/layout/details_place_page.xml @@ -40,8 +40,11 @@ android:id="@+id/ll__place_phone" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginTop="@dimen/margin_medium" - android:orientation="horizontal"> + android:layout_marginTop="@dimen/margin_small" + android:background="?attr/clickableBackground" + android:orientation="horizontal" + android:paddingBottom="@dimen/margin_small" + android:paddingTop="@dimen/margin_small"> + android:background="?attr/clickableBackground" + android:orientation="horizontal" + android:paddingBottom="@dimen/margin_small" + android:paddingTop="@dimen/margin_small"> + android:background="?attr/clickableBackground" + android:orientation="horizontal" + android:paddingBottom="@dimen/margin_small" + android:paddingTop="@dimen/margin_small"> + android:background="?attr/clickableBackground" + android:orientation="horizontal" + android:paddingBottom="@dimen/margin_small" + android:paddingTop="@dimen/margin_small"> - diff --git a/android/res/layout/fragment_color_grid.xml b/android/res/layout/fragment_color_grid.xml new file mode 100644 index 0000000000..e40faffa70 --- /dev/null +++ b/android/res/layout/fragment_color_grid.xml @@ -0,0 +1,8 @@ + + diff --git a/android/res/values/styles.xml b/android/res/values/styles.xml index 46f0cda1cf..f9827f27c3 100644 --- a/android/res/values/styles.xml +++ b/android/res/values/styles.xml @@ -81,13 +81,8 @@ bold -