From 0cb259defea18ffa19b3f35e881fbc341091cfee Mon Sep 17 00:00:00 2001 From: Ilya Grechuhin Date: Fri, 26 Feb 2016 14:19:34 +0300 Subject: [PATCH] [ios] Added Downloader_Migration_dialogue statistics event. --- iphone/Maps/Classes/MapViewController.mm | 18 +++++++++++++++--- iphone/Maps/Statistics/StatisticsStrings.h | 22 +++++++++++++--------- 2 files changed, 28 insertions(+), 12 deletions(-) diff --git a/iphone/Maps/Classes/MapViewController.mm b/iphone/Maps/Classes/MapViewController.mm index c5fb8856ca..be3f0ca75d 100644 --- a/iphone/Maps/Classes/MapViewController.mm +++ b/iphone/Maps/Classes/MapViewController.mm @@ -504,9 +504,16 @@ NSString * const kEditorSegue = @"Map2EditorSegue"; - (void)openMapsDownloader { - [Alohalytics logEvent:kAlohalyticsTapEventKey withValue:@"downloader"]; - bool const needMigrate = platform::migrate::NeedMigrate(); - [self performSegueWithIdentifier:needMigrate ? kMigrationSegue : kDownloaderSegue sender:self]; + if (platform::migrate::NeedMigrate()) + { + [Statistics logEvent:kStatDownloaderMigrationDialogue withParameters:@{kStatFrom : kStatDownloader}]; + [self performSegueWithIdentifier:kMigrationSegue sender:self]; + } + else + { + [Alohalytics logEvent:kAlohalyticsTapEventKey withValue:@"downloader"]; + [self performSegueWithIdentifier:kDownloaderSegue sender:self]; + } } - (void)openEditor @@ -598,9 +605,14 @@ NSString * const kEditorSegue = @"Map2EditorSegue"; if (![self.navigationController.topViewController isEqual:self]) return; if (countryId != kInvalidCountryId && platform::migrate::NeedMigrate()) + { + [Statistics logEvent:kStatDownloaderMigrationDialogue withParameters:@{kStatFrom : kStatMap}]; [self performSegueWithIdentifier:kMigrationSegue sender:self]; + } else + { [self.downloadDialog processViewportCountryEvent:countryId]; + } } #pragma mark - MWMFrameworkUserMarkObserver diff --git a/iphone/Maps/Statistics/StatisticsStrings.h b/iphone/Maps/Statistics/StatisticsStrings.h index d4deff989f..abbee53d80 100644 --- a/iphone/Maps/Statistics/StatisticsStrings.h +++ b/iphone/Maps/Statistics/StatisticsStrings.h @@ -24,8 +24,8 @@ static NSString * const kStatCategories = @"Categories"; static NSString * const kStatChangeBookmarkColor = @"Change bookmark color"; static NSString * const kStatChangeBookmarkDescription = @"Change bookmark description"; static NSString * const kStatChangeBookmarkGroup = @"Change bookmark group"; -static NSString * const kStatChangeMapViewStyle = @"Change map view style"; static NSString * const kStatChangeLanguage = @"Change language"; +static NSString * const kStatChangeMapViewStyle = @"Change map view style"; static NSString * const kStatChangeMeasureUnits = @"Change measure units"; static NSString * const kStatChangeNightMode = @"Change night mode"; static NSString * const kStatChangeRecentTrack = @"Change recent track"; @@ -42,19 +42,22 @@ static NSString * const kStatDestination = @"Destination"; static NSString * const kStatDeviceInfo = @"Device info"; static NSString * const kStatDeviceType = @"Device type"; static NSString * const kStatDownloadAll = @"Download all country clicks counter"; +static NSString * const kStatDownloader = @"Downloader"; +static NSString * const kStatDownloaderDialog = @"Downloader dialog"; +static NSString * const kStatDownloaderMigrationDialogue = @"Downloader_Migration_dialogue"; static NSString * const kStatDownloadMap = @"Download map"; static NSString * const kStatDownloadMaps = @"Download maps"; static NSString * const kStatDownloadRequest = @"Download request"; -static NSString * const kStatDownloaderDialog = @"Downloader dialog"; static NSString * const kStatDownloadRoute = @"Download route"; -static NSString * const kStatError = @"Error"; static NSString * const kStatEdit = @"Edit"; static NSString * const kStatEditTime = @"Edit time"; +static NSString * const kStatError = @"Error"; static NSString * const kStatExpand = @"Expand"; static NSString * const kStatExpandCategory = @"Expand category"; static NSString * const kStatExpandLargeCountry = @"Expand large country"; static NSString * const kStatExport = @"Export"; static NSString * const kStatFacebook = @"Facebook"; +static NSString * const kStatFrom = @"From"; static NSString * const kStatFromMyPosition = @"From my position"; static NSString * const kStatGo = @"Go"; static NSString * const kStatGoogle = @"Google"; @@ -63,12 +66,13 @@ static NSString * const kStatHidden = @"Hidden"; static NSString * const kStatHistory = @"History"; static NSString * const kStatImport = @"Import"; static NSString * const kStatIn = @"In"; -static NSString * const kStatKML = @"KML"; static NSString * const kStatKilometers = @"Kilometers"; +static NSString * const kStatKML = @"KML"; static NSString * const kStatLandscape = @"Landscape"; static NSString * const kStatLanguage = @"Language"; static NSString * const kStatLocation = @"Location"; static NSString * const kStatLogout = @"Logout"; +static NSString * const kStatMap = @"Map"; static NSString * const kStatMapSearch = @"Map search"; static NSString * const kStatMapViewStyle = @"Map view style"; static NSString * const kStatMapViewStyleSettings = @"Map view style settings"; @@ -98,6 +102,8 @@ static NSString * const kStatPointToPoint = @"Point to point"; static NSString * const kStatPortrait = @"Portrait"; static NSString * const kStatProgress = @"Progress"; static NSString * const kStatPushReceived = @"Push received"; +static NSString * const kStatiPad = @"iPad"; +static NSString * const kStatiPhone = @"iPhone"; static NSString * const kStatRate = @"Rate"; static NSString * const kStatRecentTrack = @"Recent track"; static NSString * const kStatRegular = @"Regular"; @@ -122,10 +128,7 @@ static NSString * const kStatSocial = @"Social"; static NSString * const kStatSource = @"Source"; static NSString * const kStatStart = @"Start"; static NSString * const kStatSwapRoutingPoints = @"Swap routing points"; -static NSString * const kStatTTS = @"TTS"; -static NSString * const kStatTTSSettings = @"TTS settings"; static NSString * const kStatTable = @"Table"; -static NSString * const kStatToMyPosition = @"To my position"; static NSString * const kStatToggleBookmark = @"Toggle bookmark"; static NSString * const kStatToggleCompassCalibration = @"Toggle compass calibration"; static NSString * const kStatToggleCoordinates = @"Toggle coordinates"; @@ -134,6 +137,9 @@ static NSString * const kStatToggleSection = @"Toggle section"; static NSString * const kStatToggleStatistics = @"Toggle statistics"; static NSString * const kStatToggleVisibility = @"Toggle visibility"; static NSString * const kStatToggleZoomButtonsVisibility = @"Toggle zoom buttons visibility"; +static NSString * const kStatToMyPosition = @"To my position"; +static NSString * const kStatTTS = @"TTS"; +static NSString * const kStatTTSSettings = @"TTS settings"; static NSString * const kStatUpdateAll = @"Update all"; static NSString * const kStatValue = @"Value"; static NSString * const kStatVehicle = @"Vehicle"; @@ -141,8 +147,6 @@ static NSString * const kStatVisible = @"Visible"; static NSString * const kStatWhatsNew = @"What's New"; static NSString * const kStatYes = @"Yes"; static NSString * const kStatZoom = @"Zoom"; -static NSString * const kStatiPad = @"iPad"; -static NSString * const kStatiPhone = @"iPhone"; static inline NSString * const kStatEventName(NSString * component, NSString * action) {