pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] taxi error tracking unification

Browse source
This commit is contained in:
Arsentiy Milchakov 2020-11-20 15:15:05 +03:00 • committed by Alexander Boriskov
parent 48e6144256
commit 24c81b4a38
3 changed files with 9 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
android/src/com/mapswithme/maps/routing/RoutingController.java
View file

@ -1209,7 +1209,7 @@ public class RoutingController implements TaxiManager.TaxiListener, Initializabl
{
mContainer.onTaxiError(error.getCode());
completeTaxiRequest();
Statistics.INSTANCE.trackTaxiError(error);
Statistics.INSTANCE.trackTaxiError(error.getTaxiType(), error.getCode());
}
}
@ -1222,7 +1222,7 @@ public class RoutingController implements TaxiManager.TaxiListener, Initializabl
{
mContainer.onTaxiError(TaxiManager.ErrorCode.NoProviders);
completeTaxiRequest();
Statistics.INSTANCE.trackNoTaxiProvidersError();
Statistics.INSTANCE.trackTaxiError(null, TaxiManager.ErrorCode.NoProviders);
}
}
}

4
android/src/com/mapswithme/maps/taxi/TaxiInfoError.java
View file

@ -22,9 +22,9 @@ public class TaxiInfoError
}
@NonNull
public String getProviderName()
public TaxiType getTaxiType()
{
return mType.getProviderName();
return mType;
}
@Override

15
android/src/com/mapswithme/util/statistics/Statistics.java
View file

@ -36,6 +36,7 @@ import com.mapswithme.maps.routing.RoutingOptions;
import com.mapswithme.maps.settings.RoadType;
import com.mapswithme.maps.taxi.TaxiInfoError;
import com.mapswithme.maps.taxi.TaxiManager;
import com.mapswithme.maps.taxi.TaxiType;
import com.mapswithme.maps.widget.menu.MainMenu;
import com.mapswithme.maps.widget.placepage.Sponsored;
import com.mapswithme.util.BatteryState;
@ -1151,18 +1152,12 @@ public enum Statistics
trackEvent(eventName, params);
}
public void trackTaxiError(@NonNull TaxiInfoError error)
public void trackTaxiError(@Nullable TaxiType type, @NonNull TaxiManager.ErrorCode code)
{
Statistics.ParameterBuilder params = Statistics.params();
params.add(Statistics.EventParam.PROVIDER, error.getProviderName());
params.add(ERROR, error.getCode().toStatisticValue());
trackEvent(EventName.ROUTING_TAXI_ROUTE_BUILT, params);
}
public void trackNoTaxiProvidersError()
{
Statistics.ParameterBuilder params = Statistics.params();
params.add(ERROR_CODE, TaxiManager.ErrorCode.NoProviders.name());
if (type != null)
params.add(Statistics.EventParam.PROVIDER, type.getProviderName());
params.add(ERROR, code.toStatisticValue());
trackEvent(EventName.ROUTING_TAXI_ROUTE_BUILT, params);
}