pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Fixed review notes

Browse source
This commit is contained in:
Dmitry Donskoy 2020-04-08 10:06:59 +03:00 • committed by Vladimir Byko-Ianko
parent 353685701f
commit 2d26f4cf08
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
android/src/com/mapswithme/maps/downloader/OnmapDownloader.java
View file

@ -106,7 +106,7 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
{
updateStateInternal(shouldAutoDownload);
if (mPromoBanner == null || !hasMapDownloading(mCurrentCountry))
if (mPromoBanner == null || !isMapDownloading(mCurrentCountry))
return;
Statistics.ParameterBuilder builder =
@ -116,7 +116,7 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
Statistics.INSTANCE.trackEvent(Statistics.EventName.DOWNLOADER_BANNER_SHOW, builder);
}
private static boolean hasMapDownloading(@Nullable CountryItem country)
private static boolean isMapDownloading(@Nullable CountryItem country)
{
if (country == null) return false;
@ -303,9 +303,8 @@ public class OnmapDownloader implements MwmActivity.LeftAnimationTrackListener
mPromoBanner = Framework.nativeGetDownloaderPromoBanner(mCurrentCountry.id);
boolean isPromoFound = mPromoBanner != null;
boolean isDownloading = hasMapDownloading(mCurrentCountry);
if (!isDownloading || !isPromoFound)
if (!isMapDownloading(mCurrentCountry) || !isPromoFound)
{
UiUtils.hide(mPromoContentDivider, mBannerContainer, mCatalogCallToActionContainer);
return;