pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Fixed the crash while clicking on Deleted Bookmark Lists

Browse source 
On Bookmarks Lists page, if a User has created a new List along with `My Places` List and then deletes it, the deleted item stays on the List. Now, if the user clicks on the deleted List Item then the app was crashing as the deleted item is unavailable. Root cause of this issue is below -
- When a `category` is deleted then `deleteCategory()` of `BookmarkManager` gets called.
- The `deleteCategory()` internally calls `nativeDeleteCategory()`.
- After a `category` is successfully deleted, then `OnBookmarksChanged()` should be invoked in order to update the List. But this wasn't happening. So deleted category wasn't getting removed from the cached list. Thus the user deleted category was visible even after deletion.
- When the user clicked on the deleted `category`, it'll eventually crash as the `category` itself isn't present

Fix: Properly notify the UI about the deleted list from BookmarkManager::NotifyChanges()
Fixes: #3828

Signed-off-by: Abhishek Bandyopadhyay <abhishek.gnit.ece@gmail.com>
Signed-off-by: Alexander Borsuk <me@alex.bio>
This commit is contained in:
Abhishek Bandyopadhyay 2023-04-27 22:04:54 +05:30 • committed by Roman Tsisyk
parent d62e543a33
commit 5670fe0ada
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
map/bookmark_manager.cpp
View file

@ -3051,8 +3051,8 @@ void BookmarkManager::MarksChangesTracker::OnDeleteGroup(kml::MarkGroupId groupI
auto const it = m_createdGroups.find(groupId);
if (it != m_createdGroups.end())
m_createdGroups.erase(it);
else
m_removedGroups.insert(groupId);
m_removedGroups.insert(groupId);
}
void BookmarkManager::MarksChangesTracker::OnUpdateGroup(kml::MarkGroupId groupId)