From 60decd4101236d7085ccd9dce0b8ebddd1103f47 Mon Sep 17 00:00:00 2001
From: Roman Tsisyk <roman@tsisyk.com>
Date: Sat, 15 Oct 2022 09:16:57 +0300
Subject: [PATCH] [android] Fix lint warnings for intent-filters (#3595)

* [android] Fix lint warnings for intent-filters

> Data tags should only declare unique attributes
> Consider splitting data tag into multiple tags
> with individual attributes to avoid confusion

All the `<data>` elements contained within the same `<intent-filter>`
element contribute to the same filter. So, for example, the following
filter specification,

```
<intent-filter . . . >
    <data android:scheme="something" android:host="project.example.com" />
    . . .
</intent-filter>
```

is equivalent to this one:

```
<intent-filter . . . >
    <data android:scheme="something" />
    <data android:host="project.example.com" />
    . . .
</intent-filter>
```

https://developer.android.com/guide/topics/manifest/data-element

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>
---
 android/AndroidManifest.xml | 68 ++++++-------------------------------
 1 file changed, 10 insertions(+), 58 deletions(-)

diff --git a/android/AndroidManifest.xml b/android/AndroidManifest.xml
index 7b8a8946a3..4dc210eb54 100644
--- a/android/AndroidManifest.xml
+++ b/android/AndroidManifest.xml
@@ -68,7 +68,6 @@
       android:name="com.mapswithme.maps.SplashActivity"
       android:exported="true">
 
-      <!-- standard "geo" scheme -->
       <intent-filter>
         <action android:name="android.intent.action.VIEW"/>
 
@@ -76,14 +75,6 @@
         <category android:name="android.intent.category.BROWSABLE"/>
 
         <data android:scheme="geo"/>
-      </intent-filter>
-
-      <intent-filter>
-        <action android:name="android.intent.action.VIEW"/>
-
-        <category android:name="android.intent.category.DEFAULT"/>
-        <category android:name="android.intent.category.BROWSABLE"/>
-
         <data android:scheme="ge0"/>
         <data android:scheme="om"/>
       </intent-filter>
@@ -94,8 +85,9 @@
         <category android:name="android.intent.category.DEFAULT"/>
         <category android:name="android.intent.category.BROWSABLE"/>
 
-        <data android:scheme="http" android:host="ge0.me"/>
+        <data android:scheme="http"/>
         <data android:scheme="https"/>
+        <data android:host="ge0.me"/>
       </intent-filter>
 
       <intent-filter android:autoVerify="@bool/autoVerify">
@@ -104,8 +96,9 @@
         <category android:name="android.intent.category.DEFAULT"/>
         <category android:name="android.intent.category.BROWSABLE"/>
 
-        <data android:scheme="http" android:host="omaps.app"/>
+        <data android:scheme="http"/>
         <data android:scheme="https"/>
+        <data android:host="omaps.app"/>
       </intent-filter>
 
       <intent-filter>
@@ -558,24 +551,10 @@
         <data android:scheme="https"/>
 
         <!-- #map=$zoom/$lat/$lon -->
-        <data android:host="www.openstreetmap.org" android:path="/"/>
-        <data android:host="www.openstreetmap.org" android:pathPrefix="/search"/>
-        <data android:host="openstreetmap.org" android:path="/"/>
-        <data android:host="openstreetmap.org" android:pathPrefix="/search"/>
-      </intent-filter>
-
-      <intent-filter>
-        <action android:name="android.intent.action.VIEW"/>
-
-        <category android:name="android.intent.category.DEFAULT"/>
-        <category android:name="android.intent.category.BROWSABLE"/>
-
-        <data
-          android:host="lead"
-          android:scheme="mapsme"/>
-        <data
-          android:host="lead"
-          android:scheme="mapswithme"/>
+        <data android:host="openstreetmap.org"/>
+        <data android:host="www.openstreetmap.org"/>
+        <data android:path="/"/>
+        <data android:path="/search"/>
       </intent-filter>
 
       <intent-filter>
@@ -602,16 +581,11 @@
         <data android:mimeType="application/vnd.google-earth.kmz"/>
       </intent-filter>
 
-      <intent-filter>
-        <action android:name="android.intent.action.SEND"/>
-        <category android:name="android.intent.category.DEFAULT"/>
-        <data android:mimeType="application/vnd.google-earth.kmz"/>
-      </intent-filter>
-
       <intent-filter>
         <action android:name="android.intent.action.SEND"/>
         <category android:name="android.intent.category.DEFAULT"/>
         <data android:mimeType="application/vnd.google-earth.kml+xml"/>
+        <data android:mimeType="application/vnd.google-earth.kmz"/>
       </intent-filter>
 
       <intent-filter>
@@ -630,35 +604,13 @@
         <data android:pathPattern=".*\\..*\\..*\\.kmz" />
         <data android:pathPattern=".*\\..*\\..*\\..*\\.kmz" />
         <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.kmz" />
-      </intent-filter>
-
-      <intent-filter>
-        <action android:name="android.intent.action.VIEW" />
-        <category android:name="android.intent.category.DEFAULT" />
-        <category android:name="android.intent.category.BROWSABLE" />
-        <data android:scheme="content"/>
-        <data android:scheme="file"/>
-        <data android:scheme="data"/>
-        <data android:host="*"/>
-        <data android:mimeType="*/*"/>
         <data android:pathPattern="*.kml"/>
         <data android:pathPattern=".*\\.kml" />
         <data android:pathPattern=".*\\..*\\.kml" />
         <data android:pathPattern=".*\\..*\\..*\\.kml" />
         <data android:pathPattern=".*\\..*\\..*\\..*\\.kml" />
         <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.kml" />
-      </intent-filter>
-
-      <!-- Old MAPS.ME binary format //-->
-      <intent-filter>
-        <action android:name="android.intent.action.VIEW"/>
-        <category android:name="android.intent.category.DEFAULT"/>
-        <category android:name="android.intent.category.BROWSABLE"/>
-        <data android:scheme="content"/>
-        <data android:scheme="file"/>
-        <data android:scheme="data"/>
-        <data android:host="*"/>
-        <data android:mimeType="*/*"/>
+        <!-- Old MAPS.ME binary format //-->
         <data android:pathPattern="*.kmb"/>
         <data android:pathPattern=".*\\.kmb" />
         <data android:pathPattern=".*\\..*\\.kmb" />