pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Removed NestedScrollView hack

Browse source 
The hack was introduced in this commit:
4a85620161

It mentions this Google issue: https://issuetracker.google.com/u/0/issues/37070828
and this source code for the hack:
https://rileymacdonald.ca/2018/08/06/android-nestedscrollview-children-require-double-click-scroll/

The latest AGP linter fails to find NestedScrollViewClickFixed class, likely because it is bound to
the external androidx.core.widget namespace instead of the app's one.

A quick testing didn't find any issues with the place page when this hack is removed.
Looks like it was already fixed in the upstream

Signed-off-by: Alexander Borsuk <me@alex.bio>
This commit is contained in:
Alexander Borsuk 2023-12-02 20:18:25 +01:00 • committed by Alexander Borsuk
parent 10135e0571
commit 6209deeffa
3 changed files with 4 additions and 2092 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2088
android/app/src/main/java/app/organicmaps/widget/NestedScrollViewClickFixed.java
View file

File diff suppressed because it is too large Load diff

4
android/app/src/main/java/app/organicmaps/widget/placepage/PlacePageController.java
View file

@ -15,7 +15,7 @@ import androidx.annotation.Nullable;
import androidx.core.graphics.Insets;
import androidx.core.view.ViewCompat;
import androidx.core.view.WindowInsetsCompat;
import androidx.core.widget.NestedScrollViewClickFixed;
import androidx.core.widget.NestedScrollView;
import androidx.fragment.app.Fragment;
import androidx.fragment.app.FragmentActivity;
import androidx.fragment.app.FragmentManager;
@ -54,7 +54,7 @@ public class PlacePageController extends Fragment implements
private static final float PREVIEW_PLUS_RATIO = 0.45f;
private BottomSheetBehavior<View> mPlacePageBehavior;
private NestedScrollViewClickFixed mPlacePage;
private NestedScrollView mPlacePage;
private ViewGroup mPlacePageContainer;
private View mPlacePageStatusBarBackground;
private ViewGroup mCoordinator;

4
android/app/src/main/res/layout/place_page_container_fragment.xml
View file

@ -11,7 +11,7 @@
android:layout_gravity="center_horizontal|top"
android:background="?ppBackground"
android:visibility="gone" />
<androidx.core.widget.NestedScrollViewClickFixed
<androidx.core.widget.NestedScrollView
android:id="@+id/placepage"
style="?attr/bottomSheetStyle"
android:elevation="0dp"
@ -28,7 +28,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content" />
</RelativeLayout>
</androidx.core.widget.NestedScrollViewClickFixed>
</androidx.core.widget.NestedScrollView>
<androidx.fragment.app.FragmentContainerView
android:id="@+id/pp_buttons_fragment"
android:layout_width="match_parent"