From 6a5dead134009a081dc01c5e3f82c7507ec8bb22 Mon Sep 17 00:00:00 2001
From: Vladimir Byko-Ianko <v.bykoianko@corp.mail.ru>
Date: Thu, 8 Sep 2016 18:19:36 +0300
Subject: [PATCH] Review fixes.

---
 map/chart_generator.cpp | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/map/chart_generator.cpp b/map/chart_generator.cpp
index da9f704172..035c9c2f25 100644
--- a/map/chart_generator.cpp
+++ b/map/chart_generator.cpp
@@ -140,9 +140,11 @@ bool NormalizeChartData(vector<double> const & distanceDataM,
 bool GenerateYAxisChartData(uint32_t height, double minMetersPerPxl,
                             vector<double> const & altitudeDataM, vector<double> & yAxisDataPxl)
 {
-  yAxisDataPxl.clear();
   if (altitudeDataM.empty())
+  {
+    yAxisDataPxl.clear();
     return true;
+  }
 
   uint32_t constexpr kHeightIndentPxl = 2;
   uint32_t heightIndentPxl = kHeightIndentPxl;
@@ -164,9 +166,9 @@ bool GenerateYAxisChartData(uint32_t height, double minMetersPerPxl,
     return false;
   }
 
-  size_t const altitudeDataSz = altitudeDataM.size();
-  yAxisDataPxl.resize(altitudeDataSz);
-  for (size_t i = 0; i < altitudeDataSz; ++i)
+  size_t const altitudeDataSize = altitudeDataM.size();
+  yAxisDataPxl.resize(altitudeDataSize);
+  for (size_t i = 0; i < altitudeDataSize; ++i)
     yAxisDataPxl[i] = height - heightIndentPxl - (altitudeDataM[i] - minAltM) / metersPerPxl;
 
   return true;
@@ -268,7 +270,6 @@ bool GenerateChart(uint32_t width, uint32_t height, vector<double> const & dista
       geometry[i] = m2::PointD(i * oneSegLenPix, yAxisDataPxl[i]);
   }
 
-  frameBuffer.clear();
   GenerateChartByPoints(width, height, geometry, mapStyle, frameBuffer);
   return true;
 }