pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[partners_api] review fixes

Browse source
This commit is contained in:
Arsentiy Milchakov 2017-11-09 12:54:27 +03:00 • committed by Yuri Gorshenin
parent f886bd939a
commit 6ba882bfe5
3 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
partners_api/booking_api.cpp
View file

@ -232,20 +232,20 @@ void FillPriceAndCurrency(string const & src, string const & currency, string &
}
}
void FillHotelIds(string const & src, vector<std::string> & result)
void FillHotelIds(string const & src, vector<std::string> & ids)
{
my::Json root(src.c_str());
auto const resultsArray = json_object_get(root.get(), "result");
auto const size = json_array_size(resultsArray);
result.resize(size);
ids.resize(size);
for (size_t i = 0; i < size; ++i)
{
auto const obj = json_array_get(resultsArray, i);
uint64_t id = 0;
FromJSONObject(obj, "hotel_id", id);
result[i] = std::to_string(id);
ids[i] = std::to_string(id);
}
}
} // namespace

7
partners_api/booking_api.hpp
View file

@ -60,11 +60,10 @@ public:
using GetMinPriceCallback = platform::SafeCallback<void(std::string const & hotelId, std::string const & price, std::string const & currency)>;
using GetHotelInfoCallback = platform::SafeCallback<void(HotelInfo const & hotelInfo)>;
// NOTE: this callback will be called NOT on main thread.
// NOTE: this callback will be called on the network thread.
using GetHotelAvailabilityCallback = std::function<void(std::vector<std::string> hotelIds)>;
/// Guarantees the preservation of the sequence of calls callbacks in accordance with
/// the sequence of method calls.
/// Callbacks will be called in the same order as methods are called.
class Api
{
public:
@ -78,7 +77,7 @@ public:
void GetMinPrice(std::string const & hotelId, std::string const & currency,
GetMinPriceCallback const & fn) const;
/// NOTE: callback will be called NOT on main thread.
/// NOTE: callback will be called on the network thread.
void GetHotelAvailability(AvailabilityParams const & params,
GetHotelAvailabilityCallback const & fn) const;

8
partners_api/booking_availability_params.cpp
View file

@ -3,9 +3,7 @@
#include "base/string_utils.hpp"
#include "private.h"
using namespace base::url;
using namespace base;
namespace
{
@ -17,9 +15,9 @@ std::string FormatTime(booking::AvailabilityParams::Time p)
namespace booking
{
Params AvailabilityParams::Get() const
url::Params AvailabilityParams::Get() const
{
Params result;
url::Params result;
result.push_back({"hotel_ids", strings::JoinStrings(m_hotelIds, ',')});
result.push_back({"checkin", FormatTime(m_checkin)});