diff --git a/android/build.gradle b/android/build.gradle index 4a467e14bf..75f8d06e1a 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -31,11 +31,11 @@ apply plugin: 'io.fabric' dependencies { // android support libs - compile 'com.android.support:support-v4:23.0.0' - compile 'com.android.support:appcompat-v7:23.0.0' - compile 'com.android.support:recyclerview-v7:22.2.1' - compile 'com.android.support:design:22.2.1' - compile 'com.android.support:cardview-v7:22.2.1' + compile 'com.android.support:support-v4:23.2.1' + compile 'com.android.support:appcompat-v7:23.2.1' + compile 'com.android.support:recyclerview-v7:23.2.1' + compile 'com.android.support:design:23.2.1' + compile 'com.android.support:cardview-v7:23.2.1' // google play services compile 'com.google.android.gms:play-services-location:8.4.0' compile 'com.google.android.gms:play-services-analytics:8.4.0' diff --git a/android/res/layout/fragment_osm_login.xml b/android/res/layout/fragment_osm_login.xml index 77a92ecc0a..ffb7c66c0f 100644 --- a/android/res/layout/fragment_osm_login.xml +++ b/android/res/layout/fragment_osm_login.xml @@ -77,7 +77,7 @@ android:layout_width="@dimen/editor_auth_btn_height" android:layout_height="@dimen/editor_auth_btn_height" android:layout_gravity="center" - android:elevation="@dimen/fab_elevation" + android:elevation="@dimen/design_fab_elevation" tools:targetApi="lollipop"/> diff --git a/android/res/layout/place_page_hotel_rating.xml b/android/res/layout/place_page_hotel_rating.xml index 864e64538d..37c3920de5 100644 --- a/android/res/layout/place_page_hotel_rating.xml +++ b/android/res/layout/place_page_hotel_rating.xml @@ -35,11 +35,10 @@ tools:text="Based on 848 hotel reviews"/> - { private static final int MAX_COUNT = 3; @@ -25,44 +25,24 @@ class ReviewAdapter extends BaseAdapter private ArrayList mItems = new ArrayList<>(); @Override - public int getCount() + public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) + { + return new ViewHolder(LayoutInflater.from(parent.getContext()) + .inflate(R.layout.item_comment, parent, false)); + } + + @Override + public void onBindViewHolder(ViewHolder holder, int position) + { + holder.bind(mItems.get(position), position > 0); + } + + @Override + public int getItemCount() { return Math.min(mItems.size(), MAX_COUNT); } - @Override - public Object getItem(int position) - { - return mItems.get(position); - } - - @Override - public long getItemId(int position) - { - return position; - } - - @Override - public View getView(int position, View convertView, ViewGroup parent) - { - ViewHolder holder; - if (convertView == null) - { - convertView = LayoutInflater.from(parent.getContext()) - .inflate(R.layout.item_comment, parent, false); - holder = new ViewHolder(convertView); - convertView.setTag(holder); - } - else - { - holder = (ViewHolder) convertView.getTag(); - } - - holder.bind(mItems.get(position), position > 0); - - return convertView; - } - public void setItems(@NonNull ArrayList items) { this.mItems = items; @@ -75,7 +55,7 @@ class ReviewAdapter extends BaseAdapter return mItems; } - private static class ViewHolder + static class ViewHolder extends RecyclerView.ViewHolder { @NonNull final View mDivider; @@ -96,6 +76,7 @@ class ReviewAdapter extends BaseAdapter public ViewHolder(View view) { + super(view); mDivider = view.findViewById(R.id.v__divider); mUserName = (TextView) view.findViewById(R.id.tv__user_name); mCommentDate = (TextView) view.findViewById(R.id.tv__comment_date); diff --git a/android/src/com/mapswithme/util/ThemeUtils.java b/android/src/com/mapswithme/util/ThemeUtils.java index 135aa57822..9ec9a4f9d1 100644 --- a/android/src/com/mapswithme/util/ThemeUtils.java +++ b/android/src/com/mapswithme/util/ThemeUtils.java @@ -6,7 +6,7 @@ import android.support.annotation.AttrRes; import android.support.annotation.ColorInt; import android.support.annotation.NonNull; import android.support.annotation.StyleRes; -import android.support.v7.internal.view.ContextThemeWrapper; +import android.support.v7.view.ContextThemeWrapper; import android.util.TypedValue; import android.view.LayoutInflater;