pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

Working on fixing the downloader tests.

Browse source 
Turns out, we have been serving wrong data, we wrote actual characters 255 instead of writing the byte 11111111, so some of our tests used to fail. What we will do now is serve bytes from 0000 to FFFF (or whatever the equivalent of the last byte in 47kb is), and we will modify our SHA in the tests accordingly.
This commit is contained in:
Timofey 2015-06-05 13:40:08 +03:00 • committed by Alex Zolotarev
parent 5184858593
commit 8becb96355
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
platform/platform_tests/downloader_test.cpp
View file

@ -433,7 +433,7 @@ UNIT_TEST(DownloadChunks)
FinishDownloadFail(FILENAME);
}
string const SHA256 = "338C28398CE42C1B2F6DCE2D288956819C08E64894B788250837653BAF5049BA";
string const SHA256 = "3CE28B04BCC3006124A5324B2B145C94F6AEC613BC4135DCEF6E57C436B41B89";
observer.Reset();
@ -541,7 +541,7 @@ UNIT_TEST(DownloadResumeChunks)
string const FILENAME = "some_test_filename_12345";
string const RESUME_FILENAME = FILENAME + RESUME_FILE_EXTENSION;
string const DOWNLOADING_FILENAME = FILENAME + DOWNLOADING_FILE_EXTENSION;
string const SHA256 = "91BF56C789DEFCB1F9E8EACDCB4C88C17BBC6615C24C394DF25DD2CD37B1B159";
string const SHA256 = "3CE28B04BCC3006124A5324B2B145C94F6AEC613BC4135DCEF6E57C436B41B89";
// remove data from previously failed files
DeleteTempDownloadFiles();
@ -607,7 +607,7 @@ UNIT_TEST(DownloadResumeChunks)
UNIT_TEST(DownloadResumeChunksWithCancel)
{
string const FILENAME = "some_test_filename_12345";
string const SHA256 = "1654E268B74B23922FD20DC3CB7926373279770FBA7BD81B5AF25F0E2D5E0A0D";
string const SHA256 = "3CE28B04BCC3006124A5324B2B145C94F6AEC613BC4135DCEF6E57C436B41B89";
// remove data from previously failed files
DeleteTempDownloadFiles();

4
tools/testserver.py
View file

@ -48,7 +48,7 @@ from scipy.stats.stats import trim_mean
PORT = 34568
LIFESPAN = 180.0 # timeout for the self destruction timer - how much time
LIFESPAN = 18000.0 # timeout for the self destruction timer - how much time
# passes between the last request and the server killing
# itself
PING_TIMEOUT = 5 # Nubmer of seconds to wait for ping response
@ -274,7 +274,7 @@ class PostHandler(BaseHTTPRequestHandler):
self.end_headers()
for i in range(0, length + 1):
# try:
self.wfile.write(255)
self.wfile.write(chr(i%256))
# except IOError, e:
# if e.errno == errno.EPIPE:
# print("This is indeed a broken pipe")