diff --git a/platform/platform_android.cpp b/platform/platform_android.cpp index 6325daae6a..0f7646062b 100644 --- a/platform/platform_android.cpp +++ b/platform/platform_android.cpp @@ -257,7 +257,7 @@ bool Platform::GetFileSizeByName(string const & fileName, uint64_t & size) const Platform::EError Platform::MkDir(string const & dirName) const { - if (mkdir(dirName.c_str(), 0755)) + if (0 != mkdir(dirName.c_str(), 0755)) return ErrnoToError(); return Platform::ERR_OK; } diff --git a/routing/async_router.cpp b/routing/async_router.cpp index 53d7cfe1d6..92e6c1d498 100644 --- a/routing/async_router.cpp +++ b/routing/async_router.cpp @@ -131,7 +131,7 @@ void AsyncRouter::LogCode(IRouter::ResultCode code, double const elapsedSec) } } -// TODO (ldragunov) write some tests to check this callback logick. +// TODO (ldragunov) write some tests to check this callback logic. void AsyncRouter::CalculateRouteImpl(TReadyCallback const & callback) { ASSERT(m_router, ()); @@ -170,7 +170,6 @@ void AsyncRouter::CalculateRouteImpl(TReadyCallback const & callback) code = m_router->CalculateRoute(startPoint, startDirection, finalPoint, route); elapsedSec = timer.ElapsedSeconds(); // routing time - LOG(LINFO, ("Router return code:")); LogCode(code, elapsedSec); } catch (RootException const & e) @@ -208,7 +207,6 @@ void AsyncRouter::CalculateRouteImpl(TReadyCallback const & callback) } } - LOG(LINFO, ("Final code:")); LogCode(code, elapsedSec); SendStatistics(startPoint, startDirection, finalPoint, code, route, elapsedSec); // Call callback only if we have some new data. diff --git a/routing/osrm_router.cpp b/routing/osrm_router.cpp index 084d6f8b74..998eddf6dd 100644 --- a/routing/osrm_router.cpp +++ b/routing/osrm_router.cpp @@ -343,7 +343,7 @@ string OsrmRouter::GetName() const void OsrmRouter::ClearState() { m_cachedTargets.clear(); - m_CachedTargetPoint = m2::PointD::Zero(); + m_cachedTargetPoint = m2::PointD::Zero(); m_indexManager.Clear(); } @@ -564,14 +564,14 @@ OsrmRouter::ResultCode OsrmRouter::CalculateRoute(m2::PointD const & startPoint, return code; } { - if (finalPoint != m_CachedTargetPoint) + if (finalPoint != m_cachedTargetPoint) { ResultCode const code = FindPhantomNodes(finalPoint, m2::PointD::Zero(), m_cachedTargets, kMaxNodeCandidatesCount, targetMapping); if (code != NoError) return code; - m_CachedTargetPoint = finalPoint; + m_cachedTargetPoint = finalPoint; } } INTERRUPT_WHEN_CANCELLED(); diff --git a/routing/osrm_router.hpp b/routing/osrm_router.hpp index 7b9327b216..37811c26e3 100644 --- a/routing/osrm_router.hpp +++ b/routing/osrm_router.hpp @@ -100,7 +100,7 @@ private: Index const * m_pIndex; TFeatureGraphNodeVec m_cachedTargets; - m2::PointD m_CachedTargetPoint; + m2::PointD m_cachedTargetPoint; RoutingIndexManager m_indexManager; TRoutingVisualizerFn m_routingVisualization;