From 9d45647828a2593ce6ba669cdddb01c977af5915 Mon Sep 17 00:00:00 2001 From: Daria Volvenkova Date: Mon, 19 Feb 2018 14:46:30 +0300 Subject: [PATCH] Warning fixed. --- map/bookmark_manager.cpp | 2 -- map/user_mark.cpp | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/map/bookmark_manager.cpp b/map/bookmark_manager.cpp index 909fde800b..28d4552b57 100644 --- a/map/bookmark_manager.cpp +++ b/map/bookmark_manager.cpp @@ -185,7 +185,6 @@ Bookmark * BookmarkManager::CreateBookmark(m2::PointD const & ptOrg, BookmarkDat Bookmark * BookmarkManager::CreateBookmark(m2::PointD const & ptOrg, BookmarkData & bm, df::MarkGroupID groupId) { - // TODO(darina): Do we need this event? GetPlatform().GetMarketingService().SendMarketingEvent(marketing::kBookmarksBookmarkAction, {{"action", "create"}}); @@ -898,7 +897,6 @@ void BookmarkManager::CreateCategories(KMLDataCollection && dataCollection, bool } if (merge) { - // TODO(darina): Change the order. // Delete file since it will be merged. my::DeleteFileX(data->m_file); SaveToKMLFile(groupId); diff --git a/map/user_mark.cpp b/map/user_mark.cpp index 2476b3cb67..dfc3bc6c63 100644 --- a/map/user_mark.cpp +++ b/map/user_mark.cpp @@ -17,7 +17,7 @@ df::MarkID GetNextUserMarkId(UserMark::Type type) { static std::atomic nextMarkId(0); - ASSERT_LESS(type, 1 << kMarkIdTypeBitsCount, ()); + static_assert(UserMark::Type::BOOKMARK < (1 << kMarkIdTypeBitsCount), "Not enough bits for user mark type."); return static_cast( (++nextMarkId) | (type << static_cast(sizeof(df::MarkID) * 8 - kMarkIdTypeBitsCount))); }