pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] call onSlideFinish only when bottomsheet is settled

Browse source 
Signed-off-by: Arnaud Vergnet <arnaud.vergnet@mailo.com>
This commit is contained in:
Arnaud Vergnet 2022-10-22 22:25:18 +02:00 • committed by Alexander Borsuk
parent 71ef628a9b
commit a7e205c181
4 changed files with 2 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
android/src/com/mapswithme/maps/widget/placepage/BottomSheetChangedListener.java
View file

@ -3,7 +3,6 @@ package com.mapswithme.maps.widget.placepage;
public interface BottomSheetChangedListener
{
void onSheetHidden();
void onSheetDirectionIconChange();
void onSheetDetailsOpened();
void onSheetCollapsed();
void onSheetSliding(int top);

11
android/src/com/mapswithme/maps/widget/placepage/DefaultBottomSheetCallback.java
View file

@ -24,9 +24,9 @@ public class DefaultBottomSheetCallback extends BottomSheetBehavior.BottomSheetC
{
Logger.d(TAG, "State change, new = " + PlacePageUtils.toString(newState));
if (PlacePageUtils.isSettlingState(newState) || PlacePageUtils.isDraggingState(newState))
{
return;
}
mSheetChangedListener.onSheetSlideFinish();
if (PlacePageUtils.isHiddenState(newState))
{
@ -34,8 +34,6 @@ public class DefaultBottomSheetCallback extends BottomSheetBehavior.BottomSheetC
return;
}
mSheetChangedListener.onSheetDirectionIconChange();
if (isExpandedState(newState))
{
mSheetChangedListener.onSheetDetailsOpened();
@ -49,10 +47,5 @@ public class DefaultBottomSheetCallback extends BottomSheetBehavior.BottomSheetC
public void onSlide(@NonNull View bottomSheet, float slideOffset)
{
mSheetChangedListener.onSheetSliding(bottomSheet.getTop());
if (slideOffset < 0)
return;
mSheetChangedListener.onSheetSlideFinish();
}
}

7
android/src/com/mapswithme/maps/widget/placepage/RichPlacePageController.java
View file

@ -7,7 +7,6 @@ import android.location.Location;
import android.os.Bundle;
import android.view.View;
import android.view.ViewGroup;
import android.view.WindowInsets;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
@ -53,12 +52,6 @@ public class RichPlacePageController implements PlacePageController, LocationLis
onHiddenInternal();
}
@Override
public void onSheetDirectionIconChange()
{
// No op.
}
@Override
public void onSheetDetailsOpened()
{

6
android/src/com/mapswithme/maps/widget/placepage/SimplePlacePageController.java
View file

@ -52,12 +52,6 @@ public class SimplePlacePageController implements PlacePageController
mStateListener.onPlacePageClosed();
}
@Override
public void onSheetDirectionIconChange()
{
// No op.
}
@Override
public void onSheetDetailsOpened()
{