From adfb45b29b090e69b2cc816b907d04c6a10e2b6c Mon Sep 17 00:00:00 2001 From: VladiMihaylenko Date: Fri, 5 Feb 2016 13:36:40 +0300 Subject: [PATCH] [ios] Refactored editor controller. --- .../MWMPlacePageOpeningHoursCell.h | 3 +- .../MWMPlacePageOpeningHoursCell.mm | 3 - .../MWMPlacePageOpeningHoursCell.xib | 39 ++-- .../Cuisine/MWMCuisineEditorTableViewCell.xib | 15 +- .../Cuisine/MWMCuisineEditorViewController.mm | 6 + .../Editor/MWMEditorNameTableViewCell.xib | 121 +++-------- .../Editor/MWMEditorSelectTableViewCell.h | 3 +- .../Editor/MWMEditorSelectTableViewCell.mm | 3 - .../Editor/MWMEditorSelectTableViewCell.xib | 18 +- .../Maps/Classes/Editor/MWMEditorSpacerCell.h | 3 - .../Maps/Classes/Editor/MWMEditorSpacerCell.m | 10 - .../Classes/Editor/MWMEditorSpacerCell.xib | 37 ---- .../Editor/MWMEditorSwitchTableViewCell.h | 3 +- .../Editor/MWMEditorSwitchTableViewCell.mm | 3 - .../Editor/MWMEditorSwitchTableViewCell.xib | 18 +- .../Classes/Editor/MWMEditorTableViewHeader.h | 5 - .../Editor/MWMEditorTableViewHeader.mm | 16 -- .../Editor/MWMEditorTableViewHeader.xib | 54 ----- .../Editor/MWMEditorTextTableViewCell.h | 5 +- .../Editor/MWMEditorTextTableViewCell.mm | 13 +- .../Editor/MWMEditorTextTableViewCell.xib | 22 +- .../Classes/Editor/MWMEditorViewController.h | 4 +- .../Classes/Editor/MWMEditorViewController.mm | 129 +++--------- .../MWMOpeningHoursAddClosedTableViewCell.xib | 24 ++- ...WMOpeningHoursAddScheduleTableViewCell.xib | 2 +- .../MWMOpeningHoursAllDayTableViewCell.xib | 25 ++- ...MWMOpeningHoursClosedSpanTableViewCell.xib | 21 +- ...MOpeningHoursDaysSelectorTableViewCell.xib | 38 ++-- ...peningHoursDeleteScheduleTableViewCell.xib | 20 +- .../MWMOpeningHoursSpacerTableViewCell.h | 5 - .../MWMOpeningHoursSpacerTableViewCell.mm | 15 -- .../MWMOpeningHoursSpacerTableViewCell.xib | 21 -- ...MOpeningHoursTimeSelectorTableViewCell.xib | 20 +- .../MWMOpeningHoursTimeSpanTableViewCell.xib | 28 +-- .../OpeningHours/MWMOpeningHoursEditorCells.h | 1 - .../MWMOpeningHoursEditorViewController.mm | 1 - .../OpeningHours/MWMOpeningHoursSection.mm | 12 +- .../MWMStreetEditorCommonTableViewCell.xib | 2 +- .../MWMStreetEditorEditTableViewCell.xib | 2 +- iphone/Maps/Classes/MWMBasePlacePageView.mm | 4 +- iphone/Maps/Classes/MWMPlacePageEntity.h | 1 - iphone/Maps/Classes/MWMPlacePageEntity.mm | 1 - iphone/Maps/Classes/PlacePageInfoCell.xib | 15 +- iphone/Maps/Classes/PlacePageLinkCell.xib | 18 +- iphone/Maps/Classes/PlacePageView.xib | 28 +-- .../Images.xcassets/Separator/Contents.json | 6 + .../separator_image.imageset/Contents.json | 26 +++ .../separator_image.png | Bin 0 -> 73 bytes .../separator_image@2x.png | Bin 0 -> 14533 bytes .../separator_image@3x.png | Bin 0 -> 14537 bytes iphone/Maps/Maps.xcodeproj/project.pbxproj | 42 ---- iphone/Maps/Mapsme.storyboard | 190 +++++++----------- iphone/Maps/UIImageView+Coloring.h | 3 +- iphone/Maps/UIImageView+Coloring.mm | 8 + 54 files changed, 343 insertions(+), 769 deletions(-) delete mode 100644 iphone/Maps/Classes/Editor/MWMEditorSpacerCell.h delete mode 100644 iphone/Maps/Classes/Editor/MWMEditorSpacerCell.m delete mode 100644 iphone/Maps/Classes/Editor/MWMEditorSpacerCell.xib delete mode 100644 iphone/Maps/Classes/Editor/MWMEditorTableViewHeader.h delete mode 100644 iphone/Maps/Classes/Editor/MWMEditorTableViewHeader.mm delete mode 100644 iphone/Maps/Classes/Editor/MWMEditorTableViewHeader.xib delete mode 100644 iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.h delete mode 100644 iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.mm delete mode 100644 iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.xib create mode 100644 iphone/Maps/Images.xcassets/Separator/Contents.json create mode 100644 iphone/Maps/Images.xcassets/Separator/separator_image.imageset/Contents.json create mode 100644 iphone/Maps/Images.xcassets/Separator/separator_image.imageset/separator_image.png create mode 100644 iphone/Maps/Images.xcassets/Separator/separator_image.imageset/separator_image@2x.png create mode 100644 iphone/Maps/Images.xcassets/Separator/separator_image.imageset/separator_image@3x.png diff --git a/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.h b/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.h index 7eb3429d13..0eed90276f 100644 --- a/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.h +++ b/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.h @@ -12,8 +12,7 @@ @interface MWMPlacePageOpeningHoursCell : UITableViewCell - (void)configWithDelegate:(id)delegate - info:(NSString *)info - lastCell:(BOOL)lastCell; + info:(NSString *)info; - (CGFloat)cellHeight; diff --git a/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.mm b/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.mm index b40fcd7656..a0c0c2e6e9 100644 --- a/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.mm +++ b/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.mm @@ -27,7 +27,6 @@ using WeekDayView = MWMPlacePageOpeningHoursDayView *; @property (weak, nonatomic) IBOutlet NSLayoutConstraint * weekDaysViewHeight; @property (nonatomic) CGFloat weekDaysViewEstimatedHeight; -@property (weak, nonatomic) IBOutlet NSLayoutConstraint * bottomSeparatorLeadingOffset; @property (weak, nonatomic) id delegate; @property (nonatomic) BOOL isClosed; @@ -64,7 +63,6 @@ WeekDayView getWeekDayView() - (void)configWithDelegate:(id)delegate info:(NSString *)info - lastCell:(BOOL)lastCell { self.delegate = delegate; WeekDayView cd = self.currentDay; @@ -74,7 +72,6 @@ WeekDayView getWeekDayView() self.expandImage.hidden = !delegate.forcedButton; self.expandImage.image = [UIImage imageNamed:@"ic_arrow_gray"]; self.expandImage.mwm_coloring = MWMImageColoringGray; - self.bottomSeparatorLeadingOffset.constant = lastCell ? 0.0 : 60.0; NSAssert(info, @"Schedule can not be empty"); osmoh::OpeningHours oh(info.UTF8String); if (MakeTimeTableSet(oh, timeTableSet)) diff --git a/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.xib b/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.xib index 15012733af..01a640a3b5 100644 --- a/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.xib +++ b/iphone/Maps/Classes/CustomViews/MapViewControls/PlacePage/Cells/OpeningHours/MWMPlacePageOpeningHoursCell.xib @@ -1,5 +1,5 @@ - + @@ -11,7 +11,7 @@ - + @@ -164,16 +164,15 @@ - + - - + - + - + @@ -181,43 +180,30 @@ - - - - - - - - - - - - - - + + - - + - + + - - + @@ -229,5 +215,6 @@ + diff --git a/iphone/Maps/Classes/Editor/Cuisine/MWMCuisineEditorTableViewCell.xib b/iphone/Maps/Classes/Editor/Cuisine/MWMCuisineEditorTableViewCell.xib index 2da786bfdd..c62f4bdfe5 100644 --- a/iphone/Maps/Classes/Editor/Cuisine/MWMCuisineEditorTableViewCell.xib +++ b/iphone/Maps/Classes/Editor/Cuisine/MWMCuisineEditorTableViewCell.xib @@ -11,7 +11,7 @@ - + - - + - - + + + @@ -63,4 +62,7 @@ + + + diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursAddScheduleTableViewCell.xib b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursAddScheduleTableViewCell.xib index 9f2d419511..63c77dde26 100644 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursAddScheduleTableViewCell.xib +++ b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursAddScheduleTableViewCell.xib @@ -11,7 +11,7 @@ - + - + - - + - + - + + - - + + + - @@ -105,5 +105,6 @@ + diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDaysSelectorTableViewCell.xib b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDaysSelectorTableViewCell.xib index 2bdda81823..2a81c2a247 100644 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDaysSelectorTableViewCell.xib +++ b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDaysSelectorTableViewCell.xib @@ -11,7 +11,7 @@ - + @@ -60,16 +60,16 @@ - + - + @@ -105,7 +105,7 @@ - + - + - - + - + - + @@ -347,6 +346,7 @@ + @@ -355,12 +355,12 @@ - + - + @@ -371,7 +371,6 @@ - @@ -408,5 +407,6 @@ + diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDeleteScheduleTableViewCell.xib b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDeleteScheduleTableViewCell.xib index 74a5b689f6..4df19ff180 100644 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDeleteScheduleTableViewCell.xib +++ b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursDeleteScheduleTableViewCell.xib @@ -11,7 +11,7 @@ - + - + - - + - + - + - - + + + - @@ -60,4 +59,7 @@ + + + diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.h b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.h deleted file mode 100644 index c09a85d3d1..0000000000 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.h +++ /dev/null @@ -1,5 +0,0 @@ -#import "MWMOpeningHoursTableViewCell.h" - -@interface MWMOpeningHoursSpacerTableViewCell : MWMOpeningHoursTableViewCell - -@end diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.mm b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.mm deleted file mode 100644 index 1352f30539..0000000000 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.mm +++ /dev/null @@ -1,15 +0,0 @@ -#import "MWMOpeningHoursSpacerTableViewCell.h" - -@implementation MWMOpeningHoursSpacerTableViewCell - -+ (CGFloat)heightForWidth:(CGFloat)width -{ - return 40.0; -} - -- (void)awakeFromNib -{ - self.backgroundColor = [UIColor clearColor]; -} - -@end diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.xib b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.xib deleted file mode 100644 index 7273312812..0000000000 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursSpacerTableViewCell.xib +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSelectorTableViewCell.xib b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSelectorTableViewCell.xib index 2fdcf34ab6..7ad1736c6a 100644 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSelectorTableViewCell.xib +++ b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSelectorTableViewCell.xib @@ -12,7 +12,7 @@ - + @@ -68,34 +68,33 @@ - + - - + - + - + + - - + - + @@ -111,4 +110,7 @@ + + + diff --git a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSpanTableViewCell.xib b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSpanTableViewCell.xib index 1ab188bfb2..477780ad46 100644 --- a/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSpanTableViewCell.xib +++ b/iphone/Maps/Classes/Editor/OpeningHours/Cells/MWMOpeningHoursTimeSpanTableViewCell.xib @@ -11,11 +11,11 @@ - +