pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[core] facebook banners in search

Browse source
This commit is contained in:
Arsentiy Milchakov 2017-04-28 14:58:02 +03:00 • committed by r.kuznetsov
parent 6976014229
commit b568f28821
6 changed files with 20 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
partners_api/ads_engine.cpp
View file

@ -1,4 +1,5 @@
#include "partners_api/ads_engine.hpp"
#include "partners_api/facebook_ads.hpp"
#include "partners_api/mopub_ads.hpp"
#include "partners_api/rb_ads.hpp"
@ -16,7 +17,7 @@ Engine::Engine()
m_banners.emplace_back(Banner::Type::RB, my::make_unique<Rb>());
m_banners.emplace_back(Banner::Type::Mopub, my::make_unique<Mopub>());
m_searchBanners.emplace_back(Banner::Type::Mopub, my::make_unique<Mopub>());
m_searchBanners.emplace_back(Banner::Type::Facebook, my::make_unique<Facebook>());
}
bool Engine::HasBanner(feature::TypesHolder const & types,

12
partners_api/facebook_ads.cpp
View file

@ -4,8 +4,10 @@ namespace
{
#if defined(OMIM_OS_IPHONE)
auto const kSingleBannerIdForAllTypes = "185237551520383_1450324925011633";
auto const kSearchbannerId = "185237551520383_1453784847998974";
#else
auto const kSingleBannerIdForAllTypes = "185237551520383_1450325641678228";
auto const kSearchbannerId = "185237551520383_1384653791578747";
#endif
} // namespace
@ -15,4 +17,14 @@ std::string Facebook::GetBannerIdForOtherTypes() const
{
return kSingleBannerIdForAllTypes;
}
bool Facebook::HasSearchBanner() const
{
return true;
}
std::string Facebook::GetSearchBannerId() const
{
return kSearchbannerId;
}
} // namespace ads

2
partners_api/facebook_ads.hpp
View file

@ -12,5 +12,7 @@ public:
// ContainerBase overrides:
std::string GetBannerIdForOtherTypes() const override;
bool HasSearchBanner() const override;
std::string GetSearchBannerId() const override;
};
} // namespace ads

10
partners_api/mopub_ads.cpp
View file

@ -77,14 +77,4 @@ std::string Mopub::GetBannerIdForOtherTypes() const
{
return kNonTourismPlacementId;
}
bool Mopub::HasSearchBanner() const
{
return true;
}
std::string Mopub::GetSearchBannerId() const
{
return kSearchBannerId;
}
} // namespace ads

2
partners_api/mopub_ads.hpp
View file

@ -12,7 +12,5 @@ public:
// ContainerBase overrides:
std::string GetBannerIdForOtherTypes() const override;
bool HasSearchBanner() const override;
std::string GetSearchBannerId() const override;
};
} // namespace ads

6
partners_api/partners_api_tests/ads_engine_tests.cpp
View file

@ -5,6 +5,7 @@
#include "indexer/feature_data.hpp"
#include "partners_api/ads_engine.hpp"
#include "partners_api/facebook_ads.hpp"
#include "partners_api/mopub_ads.hpp"
#include "partners_api/rb_ads.hpp"
@ -134,12 +135,13 @@ UNIT_TEST(AdsEngine_Smoke)
auto result = engine.GetBanners(holder, {"Russian Federation"}, "ru");
TEST(result.empty(), ());
}
ads::Facebook facebook;
{
TEST(engine.HasSearchBanner(), ());
auto result = engine.GetSearchBanners();
TEST_EQUAL(result.size(), 1, ());
TEST_EQUAL(result[0].m_type, ads::Banner::Type::Mopub, ());
TEST_EQUAL(result[0].m_bannerId, mopub.GetSearchBannerId(), ());
TEST_EQUAL(result[0].m_type, ads::Banner::Type::Facebook, ());
TEST_EQUAL(result[0].m_bannerId, facebook.GetSearchBannerId(), ());
}
}
}