From b6a67ba367290acf2731d69f564b82f56cdd939f Mon Sep 17 00:00:00 2001 From: Aleksey Belouosv Date: Thu, 26 Sep 2019 15:09:32 +0300 Subject: [PATCH] [iOS] remove references to undocumented API --- iphone/Maps/Bookmarks/BookmarksVC.mm | 19 +++---- iphone/Maps/Categories/UIKitCategories.mm | 16 ------ .../Components/MWMMailViewController.mm | 1 - .../Components/MWMNavigationController.m | 1 - .../MWMBCCreateCategoryAlert.xib | 17 ++---- .../CustomAlert/MWMPlaceDoesntExistAlert.xib | 19 ++----- .../MWMMapViewControlsManager.mm | 2 - iphone/Maps/Common/MWMCommon.h | 8 --- .../MWMBaseMapDownloaderViewController.mm | 1 - .../UI/EditBookmark/MWMBookmarkTitleCell.xib | 13 ++--- .../MWMEditorAdditionalNameTableViewCell.xib | 22 +++----- .../Cells/MWMEditorTextTableViewCell.xib | 21 +++----- .../Cuisine/MWMCuisineEditorViewController.mm | 4 -- .../MWMObjectsCategorySelectorController.mm | 4 -- .../MWMStreetEditorEditTableViewCell.xib | 19 +++---- .../Content/BookmarkCell/MWMBookmarkCell.xib | 27 +++++----- iphone/Maps/UI/Search/MWMSearchView.xib | 9 ++-- .../UI/Storyboard/Authorization.storyboard | 53 ++++++++----------- 18 files changed, 80 insertions(+), 176 deletions(-) diff --git a/iphone/Maps/Bookmarks/BookmarksVC.mm b/iphone/Maps/Bookmarks/BookmarksVC.mm index be6f3ad801..8986a3efeb 100644 --- a/iphone/Maps/Bookmarks/BookmarksVC.mm +++ b/iphone/Maps/Bookmarks/BookmarksVC.mm @@ -553,14 +553,16 @@ using namespace std; } - (void)showSpinner:(BOOL)show { - UITextField *textField = [self.searchBar valueForKey:@"searchField"]; - if (!show) { - textField.leftView = self.searchIcon; - [self.spinner stopAnimating]; - } else { - self.spinner.bounds = textField.leftView.bounds; - textField.leftView = self.spinner; - [self.spinner startAnimating]; + if (@available(iOS 13, *)) { + UITextField *textField = self.searchBar.searchTextField; + if (!show) { + textField.leftView = self.searchIcon; + [self.spinner stopAnimating]; + } else { + self.spinner.bounds = textField.leftView.bounds; + textField.leftView = self.spinner; + [self.spinner startAnimating]; + } } } @@ -569,7 +571,6 @@ using namespace std; } - (UIStatusBarStyle)preferredStatusBarStyle { - setStatusBarBackgroundColor(UIColor.clearColor); return UIStatusBarStyleLightContent; } diff --git a/iphone/Maps/Categories/UIKitCategories.mm b/iphone/Maps/Categories/UIKitCategories.mm index 56c8d06e99..4027829a6e 100644 --- a/iphone/Maps/Categories/UIKitCategories.mm +++ b/iphone/Maps/Categories/UIKitCategories.mm @@ -240,22 +240,6 @@ @end -@implementation UITextField (Refresh) - -- (void)mwm_refreshUI -{ - [super mwm_refreshUI]; - UIColor * oppositeText = self.textColor.opposite; - UILabel * placeholder = [self valueForKey:@"_placeholderLabel"]; - UIColor * oppositePlaceholder = placeholder.textColor.opposite; - if (oppositeText) - self.textColor = oppositeText; - if (oppositePlaceholder) - placeholder.textColor = oppositePlaceholder; -} - -@end - @implementation UIImageView (Refresh) - (void)mwm_refreshUI diff --git a/iphone/Maps/Classes/Components/MWMMailViewController.mm b/iphone/Maps/Classes/Components/MWMMailViewController.mm index b53d0d938c..82134a77d3 100644 --- a/iphone/Maps/Classes/Components/MWMMailViewController.mm +++ b/iphone/Maps/Classes/Components/MWMMailViewController.mm @@ -11,7 +11,6 @@ - (UIStatusBarStyle)preferredStatusBarStyle { - setStatusBarBackgroundColor(UIColor.clearColor); return UIStatusBarStyleLightContent; } diff --git a/iphone/Maps/Classes/Components/MWMNavigationController.m b/iphone/Maps/Classes/Components/MWMNavigationController.m index f9180dc0d2..0e94c89b13 100644 --- a/iphone/Maps/Classes/Components/MWMNavigationController.m +++ b/iphone/Maps/Classes/Components/MWMNavigationController.m @@ -12,7 +12,6 @@ - (UIStatusBarStyle)preferredStatusBarStyle { - setStatusBarBackgroundColor(UIColor.clearColor); return UIStatusBarStyleLightContent; } diff --git a/iphone/Maps/Classes/CustomAlert/CreateBookmarkCategory/MWMBCCreateCategoryAlert.xib b/iphone/Maps/Classes/CustomAlert/CreateBookmarkCategory/MWMBCCreateCategoryAlert.xib index cf490f40a9..0d7eec1f0e 100644 --- a/iphone/Maps/Classes/CustomAlert/CreateBookmarkCategory/MWMBCCreateCategoryAlert.xib +++ b/iphone/Maps/Classes/CustomAlert/CreateBookmarkCategory/MWMBCCreateCategoryAlert.xib @@ -1,20 +1,12 @@ - - - - + + - + - - - HelveticaNeue - HelveticaNeue-Medium - - @@ -56,7 +48,6 @@ - @@ -135,7 +126,7 @@ - + diff --git a/iphone/Maps/Classes/CustomAlert/MWMPlaceDoesntExistAlert.xib b/iphone/Maps/Classes/CustomAlert/MWMPlaceDoesntExistAlert.xib index fbc10be824..bf68f9cf82 100644 --- a/iphone/Maps/Classes/CustomAlert/MWMPlaceDoesntExistAlert.xib +++ b/iphone/Maps/Classes/CustomAlert/MWMPlaceDoesntExistAlert.xib @@ -1,24 +1,16 @@ - - - - + + - + - - - HelveticaNeue - HelveticaNeue-Medium - - - + @@ -71,7 +63,6 @@ - @@ -147,7 +138,7 @@ - + diff --git a/iphone/Maps/Classes/CustomViews/MapViewControls/MWMMapViewControlsManager.mm b/iphone/Maps/Classes/CustomViews/MapViewControls/MWMMapViewControlsManager.mm index e4c1878e81..4f5b1e467e 100644 --- a/iphone/Maps/Classes/CustomViews/MapViewControls/MWMMapViewControlsManager.mm +++ b/iphone/Maps/Classes/CustomViews/MapViewControls/MWMMapViewControlsManager.mm @@ -91,8 +91,6 @@ extern NSString * const kAlohalyticsTapEventKey; isDirectionViewUnderStatusBar || isMenuViewUnderStatusBar || isAddPlaceUnderStatusBar; - setStatusBarBackgroundColor(isSomethingUnderStatusBar ? UIColor.clearColor - : [UIColor statusBarBackground]); return isSomethingUnderStatusBar || isNightMode ? UIStatusBarStyleLightContent : UIStatusBarStyleDefault; } diff --git a/iphone/Maps/Common/MWMCommon.h b/iphone/Maps/Common/MWMCommon.h index 742e816572..9fd02cd213 100644 --- a/iphone/Maps/Common/MWMCommon.h +++ b/iphone/Maps/Common/MWMCommon.h @@ -51,11 +51,3 @@ static inline CGFloat statusBarHeight() CGSize const statusBarSize = UIApplication.sharedApplication.statusBarFrame.size; return MIN(statusBarSize.height, statusBarSize.width); } - -static inline void setStatusBarBackgroundColor(UIColor * color) -{ - UIView * statusBar = - [UIApplication.sharedApplication valueForKeyPath:@"statusBarWindow.statusBar"]; - if ([statusBar respondsToSelector:@selector(setBackgroundColor:)]) - statusBar.backgroundColor = color; -} diff --git a/iphone/Maps/UI/Downloader/MWMBaseMapDownloaderViewController.mm b/iphone/Maps/UI/Downloader/MWMBaseMapDownloaderViewController.mm index d864e75a43..7883f7007a 100644 --- a/iphone/Maps/UI/Downloader/MWMBaseMapDownloaderViewController.mm +++ b/iphone/Maps/UI/Downloader/MWMBaseMapDownloaderViewController.mm @@ -712,7 +712,6 @@ using namespace storage; - (UIStatusBarStyle)preferredStatusBarStyle { - setStatusBarBackgroundColor(UIColor.clearColor); return UIStatusBarStyleLightContent; } diff --git a/iphone/Maps/UI/EditBookmark/MWMBookmarkTitleCell.xib b/iphone/Maps/UI/EditBookmark/MWMBookmarkTitleCell.xib index 346b83919d..440b9b03e2 100644 --- a/iphone/Maps/UI/EditBookmark/MWMBookmarkTitleCell.xib +++ b/iphone/Maps/UI/EditBookmark/MWMBookmarkTitleCell.xib @@ -1,21 +1,19 @@ - - - - + + - + - + - + @@ -26,7 +24,6 @@ - diff --git a/iphone/Maps/UI/Editor/Cells/MWMEditorAdditionalNameTableViewCell.xib b/iphone/Maps/UI/Editor/Cells/MWMEditorAdditionalNameTableViewCell.xib index e4efa2cf52..9d655ad66c 100644 --- a/iphone/Maps/UI/Editor/Cells/MWMEditorAdditionalNameTableViewCell.xib +++ b/iphone/Maps/UI/Editor/Cells/MWMEditorAdditionalNameTableViewCell.xib @@ -1,26 +1,19 @@ - - - - + + - + - - - HelveticaNeue - - - + - + - + @@ -48,14 +41,13 @@ - diff --git a/iphone/Maps/UI/Search/MWMSearchView.xib b/iphone/Maps/UI/Search/MWMSearchView.xib index 567e7a165b..401e3abeb6 100644 --- a/iphone/Maps/UI/Search/MWMSearchView.xib +++ b/iphone/Maps/UI/Search/MWMSearchView.xib @@ -1,11 +1,9 @@ - - - - + + - + @@ -45,7 +43,6 @@ - diff --git a/iphone/Maps/UI/Storyboard/Authorization.storyboard b/iphone/Maps/UI/Storyboard/Authorization.storyboard index d996cfba47..4b5fa12b5e 100644 --- a/iphone/Maps/UI/Storyboard/Authorization.storyboard +++ b/iphone/Maps/UI/Storyboard/Authorization.storyboard @@ -1,30 +1,23 @@ - - - - + + - + - - - HelveticaNeue - - - + - + @@ -37,7 +30,7 @@ - + @@ -45,14 +38,13 @@ - - + @@ -62,7 +54,7 @@ - + @@ -70,7 +62,6 @@ - @@ -113,7 +104,7 @@