pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[tests] Made clang 3.5 optimization bug obvious. Need to review in future.

Browse source
This commit is contained in:
vng 2014-10-07 14:05:15 +03:00 • committed by Alex Zolotarev
parent 69b4f096f7
commit b7dc40956a
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
coding/coding_tests/varint_test.cpp
View file

@ -2,9 +2,11 @@
#include "../../testing/testing.hpp"
#include "../byte_stream.hpp"
#include "../../base/macros.hpp"
#include "../../base/stl_add.hpp"
namespace
{
template <typename T> void TestVarUint(T const x)
@ -151,16 +153,25 @@ UNIT_TEST(ReadVarInt64Array)
ASSERT_GREATER(data.size(), 0, ());
{
// Factor out variables here to show the obvious compiler error.
// clang 3.5, loop optimization.
/// @todo Need to check with the new XCode (and clang) update.
void const * pDataStart = &data[0];
void const * pDataEnd = &data[0] + data.size();
vector<int64_t> result;
void const * pEnd = ReadVarInt64Array(&data[0], &data[0] + data.size(),
void const * pEnd = ReadVarInt64Array(pDataStart, pDataEnd,
MakeBackInsertFunctor(result));
TEST_EQUAL(pEnd, &data[0] + data.size(), ("UntilBufferEnd", data.size()));
TEST_EQUAL(pEnd, pDataEnd, ("UntilBufferEnd", data.size()));
TEST_EQUAL(result, testValues, ("UntilBufferEnd", data.size()));
}
{
vector<int64_t> result;
void const * pEnd = ReadVarInt64Array(&data[0], testValues.size(),
MakeBackInsertFunctor(result));
TEST_EQUAL(pEnd, &data[0] + data.size(), ("GivenSize", data.size()));
TEST_EQUAL(result, testValues, ("GivenSize", data.size()));
}