pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Made StaticValueConverter generic

Browse source
This commit is contained in:
Александр Зацепин 2019-04-22 16:23:23 +03:00 • committed by yoksnod
parent 156a7850e3
commit bb07dc576e
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
android/src/com/mapswithme/maps/news/IntroductionDialogFragment.java
View file

@ -30,7 +30,7 @@ public class IntroductionDialogFragment extends BaseMwmDialogFragment
fragment.show(fm, IntroductionDialogFragment.class.getName());
Statistics.INSTANCE.trackEvent(Statistics.EventName.ONBOARDING_DEEPLINK_SCREEN_SHOW,
Statistics.params().add(Statistics.EventParam.TYPE,
factory.getStatisticalName()));
factory.toStatisticValue()));
}
@NonNull
@ -72,7 +72,7 @@ public class IntroductionDialogFragment extends BaseMwmDialogFragment
factory.createButtonClickListener().onIntroductionButtonClick(requireActivity(), deepLink);
Statistics.INSTANCE.trackEvent(Statistics.EventName.ONBOARDING_DEEPLINK_SCREEN_ACCEPT,
Statistics.params().add(Statistics.EventParam.TYPE,
factory.getStatisticalName()));
factory.toStatisticValue()));
dismissAllowingStateLoss();
}
@ -82,7 +82,7 @@ public class IntroductionDialogFragment extends BaseMwmDialogFragment
super.onCancel(dialog);
Statistics.INSTANCE.trackEvent(Statistics.EventName.ONBOARDING_DEEPLINK_SCREEN_DECLINE,
Statistics.params().add(Statistics.EventParam.TYPE,
getScreenFactory().getStatisticalName()));
getScreenFactory().toStatisticValue()));
}
@Override

8
android/src/com/mapswithme/maps/news/IntroductionScreenFactory.java
View file

@ -9,15 +9,15 @@ import com.mapswithme.maps.R;
import com.mapswithme.maps.bookmarks.BookmarkCategoriesActivity;
import com.mapswithme.maps.bookmarks.BookmarksCatalogActivity;
import com.mapswithme.maps.bookmarks.BookmarksPageFactory;
import com.mapswithme.util.statistics.StatisticalNameProvider;
import com.mapswithme.util.statistics.StatisticValueConverter;
public enum IntroductionScreenFactory implements StatisticalNameProvider
public enum IntroductionScreenFactory implements StatisticValueConverter<String>
{
FREE_GUIDE
{
@NonNull
@Override
public String getStatisticalName()
public String toStatisticValue()
{
return "catalogue";
}
@ -66,7 +66,7 @@ public enum IntroductionScreenFactory implements StatisticalNameProvider
{
@NonNull
@Override
public String getStatisticalName()
public String toStatisticValue()
{
return "guides_page";
}

4
android/src/com/mapswithme/util/statistics/StatisticalNameProvider.java → android/src/com/mapswithme/util/statistics/StatisticValueConverter.java
View file

@ -2,8 +2,8 @@ package com.mapswithme.util.statistics;
import android.support.annotation.NonNull;
public interface StatisticalNameProvider
public interface StatisticValueConverter<T>
{
@NonNull
public String getStatisticalName();
T toStatisticValue();
}