From bbce30f62246a170cbdac0a3df308dd9b72b7b6e Mon Sep 17 00:00:00 2001 From: VladiMihaylenko Date: Mon, 21 Mar 2016 17:49:52 +0300 Subject: [PATCH] [ios] Fixed tab buttons. --- iphone/Maps/Classes/Components/MWMButton.mm | 5 ++-- .../TabButtons/MWMSearchTabButtonsView.mm | 14 +++++---- .../TabButtons/MWMSearchTabButtonsView.xib | 30 ++++++++++--------- 3 files changed, 28 insertions(+), 21 deletions(-) diff --git a/iphone/Maps/Classes/Components/MWMButton.mm b/iphone/Maps/Classes/Components/MWMButton.mm index 79cc3079af..b5578d35f3 100644 --- a/iphone/Maps/Classes/Components/MWMButton.mm +++ b/iphone/Maps/Classes/Components/MWMButton.mm @@ -80,8 +80,9 @@ namespace else { if (self.selected) - return; - [self setDefaultTintColor]; + [self setSelected:YES]; + else + [self setDefaultTintColor]; } } diff --git a/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.mm b/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.mm index 0f04c456df..bc2157e828 100644 --- a/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.mm +++ b/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.mm @@ -8,7 +8,7 @@ static CGFloat const kIconToLabelSpacing = 4.0; @property (nonatomic) IBOutlet UIView * rootView; -@property (weak, nonatomic) IBOutlet UIImageView * icon; +@property (weak, nonatomic) IBOutlet UIButton * icon; @property (weak, nonatomic) IBOutlet UILabel * label; @property (weak, nonatomic) IBOutlet NSLayoutConstraint * iconLeft; @@ -36,8 +36,11 @@ static CGFloat const kIconToLabelSpacing = 4.0; return self; } -- (IBAction)buttonTap:(UITapGestureRecognizer *)sender +- (IBAction)buttonTap { + if (self.icon.selected) + return; + [self.delegate tabButtonPressed:self]; } @@ -80,14 +83,15 @@ static CGFloat const kIconToLabelSpacing = 4.0; - (void)setSelected:(BOOL)selected { - _selected = self.icon.highlighted = selected; + _selected = self.icon.selected = selected; self.label.textColor = selected ? UIColor.linkBlue : UIColor.blackSecondaryText; } - (void)setIconImage:(UIImage *)iconImage { - _iconImage = self.icon.image = iconImage; - [self.icon makeImageAlwaysTemplate]; + _iconImage = iconImage; + [self.icon setImage:iconImage forState:UIControlStateNormal]; + [self.icon.imageView makeImageAlwaysTemplate]; } - (void)setLocalizedText:(NSString *)localizedText diff --git a/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.xib b/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.xib index fbc4376bf2..70ac90de6a 100644 --- a/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.xib +++ b/iphone/Maps/Classes/CustomViews/MapViewControls/Search/TabButtons/MWMSearchTabButtonsView.xib @@ -1,8 +1,8 @@ - + - + @@ -11,9 +11,9 @@ - - - + + + @@ -25,16 +25,19 @@ - + -