From be2cccc50e66212075558cce9b0a2f1608bbcba4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D0=BB=D0=B5=D0=BA=D1=81=D0=B0=D0=BD=D0=B4=D1=80=20?= =?UTF-8?q?=D0=97=D0=B0=D1=86=D0=B5=D0=BF=D0=B8=D0=BD?= Date: Thu, 7 Mar 2019 20:59:45 +0300 Subject: [PATCH] [android] Added unconditional refresing of place page view, when map object is selected, i.e. for the same object refresh will be updated as well --- .../widget/placepage/BottomSheetPlacePageController.java | 9 --------- .../mapswithme/maps/widget/placepage/PlacePageView.java | 3 ++- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/android/src/com/mapswithme/maps/widget/placepage/BottomSheetPlacePageController.java b/android/src/com/mapswithme/maps/widget/placepage/BottomSheetPlacePageController.java index d683f03a03..e129bd61a9 100644 --- a/android/src/com/mapswithme/maps/widget/placepage/BottomSheetPlacePageController.java +++ b/android/src/com/mapswithme/maps/widget/placepage/BottomSheetPlacePageController.java @@ -269,17 +269,8 @@ public class BottomSheetPlacePageController implements PlacePageController, Loca mPlacePage.setMapObject(object, (policy, isSameObject) -> { @AnchorBottomSheetBehavior.State int state = mPlacePageBehavior.getState(); - // The method openFor could be invoked many times, e.g. when we leave the map and come back - // on it. So, we should do nothing if the map object is not changed or place page is already - // opened, but we have to refresh place page views, since the map object data could be changed - // while we were on the another screen (e.g. editor, ugc, settings, etc.). This behavior is - // produced by the framework 'UpdatePlacePageInfoForCurrentSelection' method that in turn calls - // method 'ActivateMapSelection'. if (isSameObject && !isHiddenState(state)) - { - mPlacePage.refreshViews(policy); return; - } mPlacePage.resetScroll(); mPlacePage.resetWebView(); diff --git a/android/src/com/mapswithme/maps/widget/placepage/PlacePageView.java b/android/src/com/mapswithme/maps/widget/placepage/PlacePageView.java index e57c258744..778d275201 100644 --- a/android/src/com/mapswithme/maps/widget/placepage/PlacePageView.java +++ b/android/src/com/mapswithme/maps/widget/placepage/PlacePageView.java @@ -1008,9 +1008,10 @@ public class PlacePageView extends NestedScrollView if (MapObject.same(mMapObject, mapObject)) { mMapObject = mapObject; + NetworkPolicy policy = NetworkPolicy.newInstance(NetworkPolicy.getCurrentNetworkUsageStatus()); + refreshViews(policy); if (listener != null) { - NetworkPolicy policy = NetworkPolicy.newInstance(NetworkPolicy.getCurrentNetworkUsageStatus()); listener.onSetMapObjectComplete(policy, true); } return;