From c4d2a0508d46905bc471e5de7821642d49005b20 Mon Sep 17 00:00:00 2001 From: Vladimir Byko-Ianko Date: Fri, 12 Aug 2016 19:46:02 +0300 Subject: [PATCH] Review fixes. --- .../com/mapswithme/maps/location/BaseLocationProvider.java | 3 ++- android/src/com/mapswithme/maps/location/LocationHelper.java | 5 +---- android/src/com/mapswithme/maps/location/TrackRecorder.java | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/android/src/com/mapswithme/maps/location/BaseLocationProvider.java b/android/src/com/mapswithme/maps/location/BaseLocationProvider.java index a2abe41544..e00f644897 100644 --- a/android/src/com/mapswithme/maps/location/BaseLocationProvider.java +++ b/android/src/com/mapswithme/maps/location/BaseLocationProvider.java @@ -41,7 +41,8 @@ abstract class BaseLocationProvider implements LocationListener if (isLocationBetterThanLast(location)) { LocationHelper.INSTANCE.resetMagneticField(location); - LocationHelper.INSTANCE.onLocationUpdated(location, true); + LocationHelper.INSTANCE.onLocationUpdated(location); + LocationHelper.INSTANCE.notifyLocationUpdated(); } } diff --git a/android/src/com/mapswithme/maps/location/LocationHelper.java b/android/src/com/mapswithme/maps/location/LocationHelper.java index 04dd269f0b..844e6c5c5e 100644 --- a/android/src/com/mapswithme/maps/location/LocationHelper.java +++ b/android/src/com/mapswithme/maps/location/LocationHelper.java @@ -237,14 +237,11 @@ public enum LocationHelper startInternal(); } - public void onLocationUpdated(@NonNull Location location, boolean notify) + public void onLocationUpdated(@NonNull Location location) { mSavedLocation = location; mMyPosition = null; mSavedLocationTime = System.currentTimeMillis(); - - if (notify) - notifyLocationUpdated(); } /** diff --git a/android/src/com/mapswithme/maps/location/TrackRecorder.java b/android/src/com/mapswithme/maps/location/TrackRecorder.java index 6ac16be8bd..d5898d7ca1 100644 --- a/android/src/com/mapswithme/maps/location/TrackRecorder.java +++ b/android/src/com/mapswithme/maps/location/TrackRecorder.java @@ -45,7 +45,7 @@ public final class TrackRecorder { log("onLocationUpdated()"); setAwaitTimeout(LOCATION_TIMEOUT_MIN_MS); - LocationHelper.INSTANCE.onLocationUpdated(location, false); + LocationHelper.INSTANCE.onLocationUpdated(location); TrackRecorderWakeService.stop(); }