pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[ios] Fixed crash.

Browse source 
MWM<Base>MapDownloaderViewController retains its dataSources.
However its tableView does not retain its dataSource.
During switch of active dataSource, tableView was loosing its dataSource.
Table reload during dataSource switch led to crashes.
This commit is contained in:
Ilya Grechuhin 2016-04-14 09:56:11 +03:00
parent 047ebf3c4a
commit cbdeaf9a97
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
iphone/Maps/Classes/MapDownloader/MWMBaseMapDownloaderViewController.mm
View file

@ -636,13 +636,12 @@ using namespace storage;
- (void)setDataSource:(MWMMapDownloaderDataSource *)dataSource
{
self.tableView.dataSource = dataSource;
self.forceFullReload = YES;
}
- (MWMMapDownloaderDataSource *)dataSource
{
return static_cast<MWMMapDownloaderDataSource *>(self.tableView.dataSource);
// Order matters. _dataSource must be set last since self.tableView does not retain dataSource.
// In different order outdated datasource gets reclaimed between assignments.
self.tableView.dataSource = dataSource;
_dataSource = dataSource;
}
#pragma mark - Helpers