From d20a514c1ead3d91a7249d509eb7c11d615a477b Mon Sep 17 00:00:00 2001 From: Kiryl Kaveryn Date: Thu, 28 Sep 2023 13:55:57 +0400 Subject: [PATCH] [ios] fix: layout and separators visibility of PlacPageInfo vc Signed-off-by: Kiryl Kaveryn --- .../UITableViewHeaderFooterViewRenderer.swift | 3 - .../PlacePageInfoViewController.swift | 34 ++- iphone/Maps/UI/PlacePage/PlacePage.storyboard | 194 +++++++++--------- .../Layouts/IPlacePageLayout.swift | 4 +- .../Layouts/PlacePageCommonLayout.swift | 20 +- .../Layouts/PlacePageElevationLayout.swift | 6 +- .../PlacePage/PlacePageViewController.swift | 41 ++-- 7 files changed, 169 insertions(+), 133 deletions(-) diff --git a/iphone/Maps/Core/Theme/Renderers/UITableViewHeaderFooterViewRenderer.swift b/iphone/Maps/Core/Theme/Renderers/UITableViewHeaderFooterViewRenderer.swift index ed7a49cf6f..16e6bcea74 100644 --- a/iphone/Maps/Core/Theme/Renderers/UITableViewHeaderFooterViewRenderer.swift +++ b/iphone/Maps/Core/Theme/Renderers/UITableViewHeaderFooterViewRenderer.swift @@ -15,9 +15,6 @@ class UITableViewHeaderFooterViewRenderer { if let backgroundColor = style.backgroundColor { control.backgroundView = UIImageView(image: backgroundColor.getImage()) } - if let font = style.font { - control.textLabel?.font = font - } if let fontColor = style.fontColor { control.textLabel?.textColor = fontColor } diff --git a/iphone/Maps/UI/PlacePage/Components/PlacePageInfoViewController.swift b/iphone/Maps/UI/PlacePage/Components/PlacePageInfoViewController.swift index 36f3153d16..0727963722 100644 --- a/iphone/Maps/UI/PlacePage/Components/PlacePageInfoViewController.swift +++ b/iphone/Maps/UI/PlacePage/Components/PlacePageInfoViewController.swift @@ -9,7 +9,6 @@ class InfoItemViewController: UIViewController { @IBOutlet var imageView: UIImageView! @IBOutlet var infoLabel: UILabel! @IBOutlet var accessoryImage: UIImageView! - @IBOutlet var separatorView: UIView! @IBOutlet var tapGestureRecognizer: UITapGestureRecognizer! var tapHandler: TapHandler? @@ -26,7 +25,6 @@ class InfoItemViewController: UIViewController { } } var canShowMenu = false - @IBAction func onTap(_ sender: UITapGestureRecognizer) { tapHandler?() } @@ -223,7 +221,6 @@ class PlacePageInfoViewController: UIViewController { } // MARK: private - private func createInfoItem(_ info: String, icon: UIImage?, style: Style = .regular, @@ -239,7 +236,36 @@ class PlacePageInfoViewController: UIViewController { private func addToStack(_ viewController: UIViewController) { addChild(viewController) - stackView.addArrangedSubview(viewController.view) + stackView.addArrangedSubviewWithSeparator(viewController.view) viewController.didMove(toParent: self) } } + +private extension UIStackView { + func addArrangedSubviewWithSeparator(_ view: UIView) { + if !arrangedSubviews.isEmpty { + view.addSeparator(thickness: CGFloat(1.0), + color: StyleManager.shared.theme?.colors.blackDividers, + insets: UIEdgeInsets(top: 0, left: 56, bottom: 0, right: 0)) + } + addArrangedSubview(view) + } +} + +private extension UIView { + func addSeparator(thickness: CGFloat, + color: UIColor?, + insets: UIEdgeInsets) { + let lineView = UIView() + lineView.backgroundColor = color ?? .black + lineView.isUserInteractionEnabled = false + lineView.translatesAutoresizingMaskIntoConstraints = false + addSubview(lineView) + NSLayoutConstraint.activate([ + lineView.heightAnchor.constraint(equalToConstant: thickness), + lineView.leadingAnchor.constraint(equalTo: leadingAnchor, constant: insets.left), + lineView.trailingAnchor.constraint(equalTo: trailingAnchor, constant: -insets.right), + lineView.topAnchor.constraint(equalTo: topAnchor, constant: insets.top), + ]) + } +} diff --git a/iphone/Maps/UI/PlacePage/PlacePage.storyboard b/iphone/Maps/UI/PlacePage/PlacePage.storyboard index da9c2ef498..b0aab3fc3e 100644 --- a/iphone/Maps/UI/PlacePage/PlacePage.storyboard +++ b/iphone/Maps/UI/PlacePage/PlacePage.storyboard @@ -1,9 +1,9 @@ - + - + @@ -20,17 +20,17 @@ - + - + - + @@ -53,7 +53,7 @@ - + @@ -63,7 +63,7 @@ - + @@ -86,7 +86,7 @@ - + @@ -124,7 +124,7 @@ - + - + - - - - + @@ -440,12 +460,12 @@ - + + - + - @@ -463,7 +483,7 @@ - + @@ -510,7 +530,7 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -604,16 +650,6 @@ - - - - - - - - - - @@ -621,12 +657,9 @@ - - - @@ -645,7 +678,6 @@ - @@ -661,7 +693,7 @@ - + @@ -729,7 +761,7 @@ @@ -782,16 +814,6 @@ - - - - - - - - - - @@ -799,10 +821,7 @@ - - - @@ -1386,21 +1405,21 @@ - + - + - - + + - - + + @@ -1413,7 +1432,7 @@ - + @@ -1488,7 +1507,7 @@ -