From d2e015f16fbf5714784a07c67b1284920cf80f5e Mon Sep 17 00:00:00 2001 From: Alexander Borsuk Date: Thu, 26 Aug 2021 00:23:46 +0200 Subject: [PATCH] Fixed curl params for HEAD requests Signed-off-by: Alexander Borsuk --- platform/http_client_curl.cpp | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/platform/http_client_curl.cpp b/platform/http_client_curl.cpp index e506ea0af6..7831fae39d 100644 --- a/platform/http_client_curl.cpp +++ b/platform/http_client_curl.cpp @@ -188,7 +188,15 @@ bool HttpClient::RunHttpRequest() ScopedRemoveFile body_deleter; ScopedRemoveFile received_file_deleter; - std::string cmd = "curl -s -w '%{http_code}' -X " + m_httpMethod + " -D '" + headers_deleter.m_fileName + "' "; + std::string cmd = "curl -s -w '%{http_code}' -D '" + headers_deleter.m_fileName + "' "; + // From curl manual: + // This option [-X] only changes the actual word used in the HTTP request, it does not alter + // the way curl behaves. So for example if you want to make a proper + // HEAD request, using -X HEAD will not suffice. You need to use the -I, --head option. + if (m_httpMethod == "HEAD") + cmd += "-I "; + else + cmd += "-X " + m_httpMethod + " "; for (auto const & header : m_headers) {