pastk/organicmaps
1
Fork 0
forked from organicmaps/organicmaps
Code Pull requests Activity

[android] Fix NPE in AlertDialog.setOnShowListener() lambda

Browse source 
Touching at the same time Add street and back button generates two events
in the event loop - one to show EditTextDialogFragment and another is to
close the activity. `editTextDialog.setOnShowListener((dialog) -> {`
callback is called when activity has gone already.

Signed-off-by: Roman Tsisyk <roman@tsisyk.com>
This commit is contained in:
Roman Tsisyk 2023-11-23 08:42:30 +02:00
parent fc3302a011
commit de2b623fed
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
android/app/src/main/java/app/organicmaps/dialog/EditTextDialogFragment.java
View file

@ -128,7 +128,10 @@ public class EditTextDialogFragment extends BaseMwmDialogFragment
// Wait till alert is shown to get mPositiveButton.
editTextDialog.setOnShowListener((dialog) -> {
mPositiveButton = editTextDialog.getButton(DialogInterface.BUTTON_POSITIVE);
this.validateInput(requireActivity(), mInitialText);
final FragmentActivity activity = getActivity();
if (activity == null)
return;
this.validateInput(activity, mInitialText);
});
// Setup validation on input edit.
@ -137,7 +140,10 @@ public class EditTextDialogFragment extends BaseMwmDialogFragment
@Override
public void onTextChanged(CharSequence s, int start, int before, int count)
{
EditTextDialogFragment.this.validateInput(requireActivity(), s.toString());
final FragmentActivity activity = getActivity();
if (activity == null)
return;
EditTextDialogFragment.this.validateInput(activity, s.toString());
}
});