Review fixes.

This commit is contained in:
Lev Dragunov 2016-04-05 12:55:40 +03:00
parent b5efa95330
commit e91a1892c0
3 changed files with 6 additions and 6 deletions

View file

@ -183,8 +183,7 @@ OsrmRouter::ResultCode OsrmRouter::MakeRouteFromCrossesPath(TCheckedPath const &
points.pop_back();
turnsDir.pop_back();
times.pop_back();
if (streets.back().first >= points.size())
streets.pop_back();
// Streets might not point to the last point of the path.
}
// Get annotated route.
@ -478,7 +477,7 @@ OsrmRouter::ResultCode OsrmRouter::MakeTurnAnnotation(
// Street names. I put empty names too, to avoid freezing old street name while riding on
// unnamed street.
streets.emplace_back(max(points.size(), (size_t)1) - 1, loadedSegment.m_name);
streets.emplace_back(max(points.size(), static_cast<size_t>(1)) - 1, loadedSegment.m_name);
// Turns information.
if (segmentIndex > 0 && !points.empty() && skipTurnSegments == 0)

View file

@ -156,7 +156,8 @@ void Route::GetCurrentStreetName(string & name) const
auto it = GetCurrentStreetNameIterAfter(m_poly.GetCurrentIter());
if (it == m_streets.cend())
name.clear();
name = it->second;
else
name = it->second;
}
void Route::GetStreetNameAfterIdx(uint32_t idx, string & name) const
@ -191,7 +192,7 @@ Route::TStreets::const_iterator Route::GetCurrentStreetNameIterAfter(FollowedPol
{
++prevIter;
++curIter;
if (curIter==m_streets.cend())
if (curIter == m_streets.cend())
return curIter;
}
return curIter->first == iter.m_ind ? curIter : prevIter;

View file

@ -27,10 +27,10 @@ SOURCES += \
cross_section_tests.cpp \
online_cross_tests.cpp \
osrm_route_test.cpp \
osrm_street_names_test.cpp \
osrm_turn_test.cpp \
pedestrian_route_test.cpp \
routing_test_tools.cpp \
osrm_street_names_test.cpp \
HEADERS += \
routing_test_tools.hpp \